From bb6021e6f881d79800af12604dddb2ede942c46e Mon Sep 17 00:00:00 2001 From: braks <78412429+bcakmakoglu@users.noreply.github.com> Date: Wed, 8 Nov 2023 18:07:28 +0100 Subject: [PATCH 1/3] fix(react,svelte): allow panning by scroll when pan activation key is pressed --- packages/react/src/container/FlowRenderer/index.tsx | 3 ++- packages/svelte/src/lib/container/Zoom/Zoom.svelte | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/react/src/container/FlowRenderer/index.tsx b/packages/react/src/container/FlowRenderer/index.tsx index 442cc2bf..bb92f66a 100644 --- a/packages/react/src/container/FlowRenderer/index.tsx +++ b/packages/react/src/container/FlowRenderer/index.tsx @@ -50,7 +50,7 @@ const FlowRenderer = ({ elementsSelectable, zoomOnScroll, zoomOnPinch, - panOnScroll, + panOnScroll: _panOnScroll, panOnScrollSpeed, panOnScrollMode, zoomOnDoubleClick, @@ -72,6 +72,7 @@ const FlowRenderer = ({ const panActivationKeyPressed = useKeyPress(panActivationKeyCode); const panOnDrag = panActivationKeyPressed || _panOnDrag; + const panOnScroll = panActivationKeyPressed || _panOnScroll; const isSelecting = selectionKeyPressed || (selectionOnDrag && panOnDrag !== true); useGlobalKeyHandler({ deleteKeyCode, multiSelectionKeyCode }); diff --git a/packages/svelte/src/lib/container/Zoom/Zoom.svelte b/packages/svelte/src/lib/container/Zoom/Zoom.svelte index d86a8505..116586ad 100644 --- a/packages/svelte/src/lib/container/Zoom/Zoom.svelte +++ b/packages/svelte/src/lib/container/Zoom/Zoom.svelte @@ -33,6 +33,7 @@ $: viewPort = initialViewport || { x: 0, y: 0, zoom: 1 }; $: _panOnDrag = $panActivationKeyPressed || panOnDrag; + $: _panOnScroll = $panActivationKeyPressed || panOnScroll;
Date: Wed, 8 Nov 2023 18:08:35 +0100 Subject: [PATCH 2/3] chore(changeset): add --- .changeset/empty-bobcats-taste.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .changeset/empty-bobcats-taste.md diff --git a/.changeset/empty-bobcats-taste.md b/.changeset/empty-bobcats-taste.md new file mode 100644 index 00000000..aa8b6cef --- /dev/null +++ b/.changeset/empty-bobcats-taste.md @@ -0,0 +1,6 @@ +--- +'@xyflow/react': patch +'@xyflow/svelte': patch +--- + +Allow panning by scroll when pan activation key is pressed. Fixes [#3516](https://github.com/xyflow/xyflow/issues/3516) From 61648488aa2d9b50c22439c4a322878b873f2205 Mon Sep 17 00:00:00 2001 From: moklick Date: Thu, 9 Nov 2023 17:18:47 +0100 Subject: [PATCH 3/3] chore(changeset): remove --- .changeset/README.md | 8 -------- .changeset/config.json | 11 ----------- .changeset/empty-bobcats-taste.md | 6 ------ 3 files changed, 25 deletions(-) delete mode 100644 .changeset/README.md delete mode 100644 .changeset/config.json delete mode 100644 .changeset/empty-bobcats-taste.md diff --git a/.changeset/README.md b/.changeset/README.md deleted file mode 100644 index e5b6d8d6..00000000 --- a/.changeset/README.md +++ /dev/null @@ -1,8 +0,0 @@ -# Changesets - -Hello and welcome! This folder has been automatically generated by `@changesets/cli`, a build tool that works -with multi-package repos, or single-package repos to help you version and publish your code. You can -find the full documentation for it [in our repository](https://github.com/changesets/changesets) - -We have a quick list of common questions to get you started engaging with this project in -[our documentation](https://github.com/changesets/changesets/blob/main/docs/common-questions.md) diff --git a/.changeset/config.json b/.changeset/config.json deleted file mode 100644 index 5980f269..00000000 --- a/.changeset/config.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "$schema": "https://unpkg.com/@changesets/config@2.1.1/schema.json", - "changelog": ["@changesets/changelog-github", { "repo": "wbkd/react-flow" }], - "commit": false, - "fixed": [], - "linked": [], - "access": "public", - "baseBranch": "main", - "updateInternalDependencies": "patch", - "ignore": [] -} diff --git a/.changeset/empty-bobcats-taste.md b/.changeset/empty-bobcats-taste.md deleted file mode 100644 index aa8b6cef..00000000 --- a/.changeset/empty-bobcats-taste.md +++ /dev/null @@ -1,6 +0,0 @@ ---- -'@xyflow/react': patch -'@xyflow/svelte': patch ---- - -Allow panning by scroll when pan activation key is pressed. Fixes [#3516](https://github.com/xyflow/xyflow/issues/3516)