From c61a9f3c9bbdb2cbd51a0f842d2734bcdfdfb16b Mon Sep 17 00:00:00 2001 From: moklick Date: Wed, 20 Sep 2023 15:51:17 +0200 Subject: [PATCH] chore(svelte): cleanup node drag handlers, add to changelog --- examples/svelte/src/routes/overview/+page.svelte | 2 +- packages/svelte/CHANGELOG.md | 5 +++++ .../svelte/src/lib/container/SvelteFlow/SvelteFlow.svelte | 2 +- packages/svelte/src/lib/container/SvelteFlow/types.ts | 2 +- 4 files changed, 8 insertions(+), 3 deletions(-) diff --git a/examples/svelte/src/routes/overview/+page.svelte b/examples/svelte/src/routes/overview/+page.svelte index 38a79a3f..c975744f 100644 --- a/examples/svelte/src/routes/overview/+page.svelte +++ b/examples/svelte/src/routes/overview/+page.svelte @@ -164,7 +164,6 @@ on:connectend={(event) => console.log('on connect end', event)} on:paneclick={(event) => console.log('on pane click', event)} on:panecontextmenu={(event) => { - event.preventDefault(); console.log('on pane contextmenu', event); }} on:nodedrag={(event) => { @@ -177,6 +176,7 @@ console.log('on node drag stop', event); }} on:nodecontextmenu={(event) => { + event.detail.event.preventDefault(); console.log('on node contextmenu', event); }} > diff --git a/packages/svelte/CHANGELOG.md b/packages/svelte/CHANGELOG.md index 491aa21f..30da979c 100644 --- a/packages/svelte/CHANGELOG.md +++ b/packages/svelte/CHANGELOG.md @@ -1,3 +1,8 @@ +## 0.0.21 + +- add `on:nodedragstart`, `on:nodedrag` and `on:nodedragstop` +- add `on:nodecontextmenu` + ## 0.0.20 - [breaking change] use same convention for all custom events: Always pass the original event if possible and additional data diff --git a/packages/svelte/src/lib/container/SvelteFlow/SvelteFlow.svelte b/packages/svelte/src/lib/container/SvelteFlow/SvelteFlow.svelte index 18b0c722..0b2fac70 100644 --- a/packages/svelte/src/lib/container/SvelteFlow/SvelteFlow.svelte +++ b/packages/svelte/src/lib/container/SvelteFlow/SvelteFlow.svelte @@ -154,8 +154,8 @@ on:connectstart on:connect on:connectend - on:nodedrag on:nodedragstart + on:nodedrag on:nodedragstop on:nodecontextmenu /> diff --git a/packages/svelte/src/lib/container/SvelteFlow/types.ts b/packages/svelte/src/lib/container/SvelteFlow/types.ts index 61e3f8c8..1c2f6ebb 100644 --- a/packages/svelte/src/lib/container/SvelteFlow/types.ts +++ b/packages/svelte/src/lib/container/SvelteFlow/types.ts @@ -75,8 +75,8 @@ export type SvelteFlowProps = DOMAttributes & { 'on:connectend'?: CustomEvent<{ event: MouseEvent | TouchEvent }>; 'on:paneclick'?: CustomEvent<{ event: MouseEvent | TouchEvent }>; 'on:panecontextmenu'?: CustomEvent<{ event: MouseEvent }>; + 'on:nodedragstart'?: CustomEvent<{ event: MouseEvent; node: NodeBase; nodes: NodeBase[] }>; 'on:nodedrag'?: CustomEvent<{ event: MouseEvent; node: NodeBase; nodes: NodeBase[] }>; 'on:nodedragstop'?: CustomEvent<{ event: MouseEvent; node: NodeBase; nodes: NodeBase[] }>; - 'on:nodedragstart'?: CustomEvent<{ event: MouseEvent; node: NodeBase; nodes: NodeBase[] }>; 'on:nodecontextmenu'?: CustomEvent<{ event: MouseEvent; node: NodeBase }>; };