From c6bc8a5580fdfaebcbc1f631c8bedf7698459032 Mon Sep 17 00:00:00 2001
From: moklick <info@moritzklack.com>
Date: Mon, 7 Oct 2019 22:37:45 +0200
Subject: [PATCH] refactor(utils): throw error when elements have no id

---
 src/utils/graph.js | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/utils/graph.js b/src/utils/graph.js
index 95feb4cd..a7427099 100644
--- a/src/utils/graph.js
+++ b/src/utils/graph.js
@@ -26,8 +26,6 @@ export const removeElements = (elements, elementsToRemove) => {
   });
 };
 
-const getEdgeId = (e) => `react-flow__edge-${e.source}-${e.target}`;
-
 const pointToRendererPoint = ({ x, y }, transform) => {
   const rendererX = (x - transform[0]) * (1 / [transform[2]]);
   const rendererY = (y - transform[1]) * (1 / [transform[2]]);
@@ -39,11 +37,15 @@ const pointToRendererPoint = ({ x, y }, transform) => {
 };
 
 export const parseElement = (e, transform) => {
+  if (!e.id) {
+    throw new Error('All elements (nodes and edges) need to have an id.',)
+  }
+
   if (isEdge(e)) {
     return {
       ...e,
-      type: e.type || 'default',
-      id: e.id ? e.id.toString() : getEdgeId(e)
+      id: e.id.toString(),
+      type: e.type || 'default'
     };
   }