From c9b1b78edf39278f33973eab6c68f45a4c730ec3 Mon Sep 17 00:00:00 2001 From: peterkogo Date: Tue, 30 Jan 2024 13:25:02 +0100 Subject: [PATCH] use for..of instead of forEach --- .../NodeResizer/NodeResizeControl.tsx | 4 ++-- .../src/lib/plugins/NodeResizer/ResizeControl.svelte | 4 ++-- packages/system/src/xyresizer/XYResizer.ts | 8 ++++---- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/packages/react/src/additional-components/NodeResizer/NodeResizeControl.tsx b/packages/react/src/additional-components/NodeResizer/NodeResizeControl.tsx index c76642ed..c03c023e 100644 --- a/packages/react/src/additional-components/NodeResizer/NodeResizeControl.tsx +++ b/packages/react/src/additional-components/NodeResizer/NodeResizeControl.tsx @@ -90,14 +90,14 @@ function ResizeControl({ changes.push(dimensionChange); } - childChanges.forEach((childChange) => { + for (const childChange of childChanges) { const positionChange: NodePositionChange = { ...childChange, type: 'position', }; changes.push(positionChange); - }); + } triggerNodeChanges(changes); }, diff --git a/packages/svelte/src/lib/plugins/NodeResizer/ResizeControl.svelte b/packages/svelte/src/lib/plugins/NodeResizer/ResizeControl.svelte index 3ec0ad71..56caa8b5 100644 --- a/packages/svelte/src/lib/plugins/NodeResizer/ResizeControl.svelte +++ b/packages/svelte/src/lib/plugins/NodeResizer/ResizeControl.svelte @@ -77,12 +77,12 @@ ? { x: change.x, y: change.y } : node.position; - childChanges.forEach((childChange) => { + for (const childChange of childChanges) { const childNode = $nodeLookup.get(childChange.id); if (childNode) { childNode.position = childChange.position; } - }); + } $nodes = $nodes; } diff --git a/packages/system/src/xyresizer/XYResizer.ts b/packages/system/src/xyresizer/XYResizer.ts index b2251834..5fe6af91 100644 --- a/packages/system/src/xyresizer/XYResizer.ts +++ b/packages/system/src/xyresizer/XYResizer.ts @@ -144,7 +144,7 @@ export function XYResizer({ domNode, nodeId, getStoreItems, onChange }: XYResize // Determine largest minimal extent the parent node is allowed to resize to childNodes = []; childExtent = undefined; - nodeLookup.forEach((child, childId) => { + for (const [childId, child] of nodeLookup) { if (child.parentNode === nodeId) { childNodes.push({ id: childId, @@ -163,7 +163,7 @@ export function XYResizer({ domNode, nodeId, getStoreItems, onChange }: XYResize } } } - }); + } onResizeStart?.(event, { ...prevValues }); } @@ -222,13 +222,13 @@ export function XYResizer({ domNode, nodeId, getStoreItems, onChange }: XYResize if (childNodes.length > 0) { const xChange = x - prevX; const yChange = y - prevY; - childNodes.forEach((childNode) => { + for (const childNode of childNodes) { childNode.position = { x: childNode.position.x - xChange, y: childNode.position.y - yChange, }; childChanges.push(childNode); - }); + } } }