From d142725ecc02da577283812fc6e557b4711ad283 Mon Sep 17 00:00:00 2001 From: moklick Date: Fri, 25 Nov 2022 21:48:33 +0100 Subject: [PATCH 1/2] fix(isRectObj): repair test for rect closes #2597 --- packages/core/src/utils/index.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/core/src/utils/index.ts b/packages/core/src/utils/index.ts index 02cff5a0..d869a81a 100644 --- a/packages/core/src/utils/index.ts +++ b/packages/core/src/utils/index.ts @@ -53,7 +53,8 @@ export const getOverlappingArea = (rectA: Rect, rectB: Rect): number => { }; // eslint-disable-next-line @typescript-eslint/no-explicit-any -export const isRectObject = (obj: any): obj is Rect => !!obj.width && !!obj.height && !!obj.x && !!obj.y; +export const isRectObject = (obj: any): obj is Rect => + isNumeric(obj.width) && isNumeric(obj.height) && isNumeric(obj.x) && isNumeric(obj.y); /* eslint-disable-next-line @typescript-eslint/no-explicit-any */ export const isNumeric = (n: any): n is number => !isNaN(n) && isFinite(n); From b2c728137d1b53e38883f044fa447585c377a6af Mon Sep 17 00:00:00 2001 From: moklick Date: Fri, 25 Nov 2022 21:50:15 +0100 Subject: [PATCH 2/2] chore(changest): add --- .changeset/silver-dots-try.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/silver-dots-try.md diff --git a/.changeset/silver-dots-try.md b/.changeset/silver-dots-try.md new file mode 100644 index 00000000..23994cc4 --- /dev/null +++ b/.changeset/silver-dots-try.md @@ -0,0 +1,5 @@ +--- +'@reactflow/core': patch +--- + +fix isRectObject function