From 45a4a977c584d7d9f14030137e77aebebaf209fc Mon Sep 17 00:00:00 2001 From: peterkogo Date: Tue, 10 Feb 2026 16:02:43 +0100 Subject: [PATCH 1/3] Always use latest version of onConnectEnd & isValidConnection in Handle/ReconnectAnchors --- .../components/EdgeWrapper/EdgeUpdateAnchors.tsx | 6 ++---- packages/react/src/components/Handle/index.tsx | 4 ++-- .../EdgeReconnectAnchor.svelte | 4 ++-- .../src/lib/components/Handle/Handle.svelte | 15 ++++----------- 4 files changed, 10 insertions(+), 19 deletions(-) diff --git a/packages/react/src/components/EdgeWrapper/EdgeUpdateAnchors.tsx b/packages/react/src/components/EdgeWrapper/EdgeUpdateAnchors.tsx index 36a983aa..87504702 100644 --- a/packages/react/src/components/EdgeWrapper/EdgeUpdateAnchors.tsx +++ b/packages/react/src/components/EdgeWrapper/EdgeUpdateAnchors.tsx @@ -53,12 +53,10 @@ export function EdgeUpdateAnchors({ const { autoPanOnConnect, domNode, - isValidConnection, connectionMode, connectionRadius, lib, onConnectStart, - onConnectEnd, cancelConnection, nodeLookup, rfId: flowId, @@ -93,10 +91,10 @@ export function EdgeUpdateAnchors({ flowId, cancelConnection, panBy, - isValidConnection, + isValidConnection: (...args) => store.getState().isValidConnection?.(...args) ?? true, onConnect: onConnectEdge, onConnectStart: _onConnectStart, - onConnectEnd, + onConnectEnd: (...args) => store.getState().onConnectEnd?.(...args), onReconnectEnd: _onReconnectEnd, updateConnection, getTransform: () => store.getState().transform, diff --git a/packages/react/src/components/Handle/index.tsx b/packages/react/src/components/Handle/index.tsx index dec2d242..1f0dc834 100644 --- a/packages/react/src/components/Handle/index.tsx +++ b/packages/react/src/components/Handle/index.tsx @@ -142,10 +142,10 @@ function HandleComponent( panBy: currentStore.panBy, cancelConnection: currentStore.cancelConnection, onConnectStart: currentStore.onConnectStart, - onConnectEnd: currentStore.onConnectEnd, + onConnectEnd: (...args) => store.getState().onConnectEnd?.(...args), updateConnection: currentStore.updateConnection, onConnect: onConnectExtended, - isValidConnection: isValidConnection || currentStore.isValidConnection, + isValidConnection: isValidConnection || ((...args) => store.getState().isValidConnection?.(...args) ?? true), getTransform: () => store.getState().transform, getFromHandle: () => store.getState().connection.fromHandle, autoPanSpeed: currentStore.autoPanSpeed, diff --git a/packages/svelte/src/lib/components/EdgeReconnectAnchor/EdgeReconnectAnchor.svelte b/packages/svelte/src/lib/components/EdgeReconnectAnchor/EdgeReconnectAnchor.svelte index 2a4975df..dbca1acf 100644 --- a/packages/svelte/src/lib/components/EdgeReconnectAnchor/EdgeReconnectAnchor.svelte +++ b/packages/svelte/src/lib/components/EdgeReconnectAnchor/EdgeReconnectAnchor.svelte @@ -79,9 +79,9 @@ flowId, cancelConnection, panBy, - isValidConnection, + isValidConnection: (...args) => store.isValidConnection?.(...args) ?? true, onConnectStart: _onConnectStart, - onConnectEnd: onconnectend, + onConnectEnd: (...args) => store.onconnectend?.(...args), onConnect: (connection) => { const reconnectedEdge = { ...edge, ...connection }; const newEdge = onbeforereconnect diff --git a/packages/svelte/src/lib/components/Handle/Handle.svelte b/packages/svelte/src/lib/components/Handle/Handle.svelte index 15f811b1..e7756289 100644 --- a/packages/svelte/src/lib/components/Handle/Handle.svelte +++ b/packages/svelte/src/lib/components/Handle/Handle.svelte @@ -125,21 +125,14 @@ autoPanOnConnect: store.autoPanOnConnect, autoPanSpeed: store.autoPanSpeed, flowId: store.flowId, - isValidConnection: isValidConnection ?? store.isValidConnection, + isValidConnection: + isValidConnection || ((...args) => store.isValidConnection?.(...args) ?? true), updateConnection: store.updateConnection, cancelConnection: store.cancelConnection, panBy: store.panBy, onConnect: onConnectExtended, - onConnectStart: (event, startParams) => { - store.onconnectstart?.(event, { - nodeId: startParams.nodeId, - handleId: startParams.handleId, - handleType: startParams.handleType - }); - }, - onConnectEnd: (event, connectionState) => { - store.onconnectend?.(event, connectionState); - }, + onConnectStart: store.onconnectstart, + onConnectEnd: (...args) => store.onconnectend?.(...args), getTransform: () => [store.viewport.x, store.viewport.y, store.viewport.zoom], getFromHandle: () => store.connection.fromHandle, dragThreshold: store.connectionDragThreshold, From c91d3d022f4517f4403a898cd02ee891b7e1f2d2 Mon Sep 17 00:00:00 2001 From: peterkogo Date: Wed, 18 Feb 2026 10:49:43 +0100 Subject: [PATCH 2/3] chore(changeset) --- .changeset/blue-shirts-beg.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .changeset/blue-shirts-beg.md diff --git a/.changeset/blue-shirts-beg.md b/.changeset/blue-shirts-beg.md new file mode 100644 index 00000000..dcbf1a54 --- /dev/null +++ b/.changeset/blue-shirts-beg.md @@ -0,0 +1,6 @@ +--- +'@xyflow/react': patch +'@xyflow/svelte': patch +--- + +Fix updating onConnectEnd and isValidConnection after connection started From e3c1f42e9a32b07f1f1ef65ee9685a1c34fa017d Mon Sep 17 00:00:00 2001 From: Moritz Klack Date: Wed, 18 Feb 2026 11:15:02 +0100 Subject: [PATCH 3/3] Update connection status during ongoing connection --- .changeset/blue-shirts-beg.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/blue-shirts-beg.md b/.changeset/blue-shirts-beg.md index dcbf1a54..21713fb5 100644 --- a/.changeset/blue-shirts-beg.md +++ b/.changeset/blue-shirts-beg.md @@ -3,4 +3,4 @@ '@xyflow/svelte': patch --- -Fix updating onConnectEnd and isValidConnection after connection started +Keep `onConnectEnd` and `isValidConnection` up to date in an ongoing connection