Merge pull request #5420 from ShlomoGalle/chore/fix-node-domattributes-type

chore(types): omit defaultValue from Node domAttributes to fix Redux typing issue #5418

.changeset/chilly-donkeys-relax.md

@@ -0,0 +1,6 @@
+---
+'@xyflow/react': patch
+'@xyflow/svelte': patch
+---
+
+Omit `defaultValue` from `Node`'s and `Edge`'s `domAttributes` to fix type incompatibility when using `WritableDraft`

packages/react/src/types/edges.ts

@@ -72,7 +72,10 @@ export type Edge<
     /**
      * General escape hatch for adding custom attributes to the edge's DOM element.
      */
-    domAttributes?: Omit<SVGAttributes<SVGGElement>, 'id' | 'style' | 'className' | 'role' | 'aria-label'>;
+    domAttributes?: Omit<
+      SVGAttributes<SVGGElement>,
+      'id' | 'style' | 'className' | 'role' | 'aria-label' | 'defaultValue'
+    >;
   };
 
 type SmoothStepEdge<EdgeData extends Record<string, unknown> = Record<string, unknown>> = Edge<

packages/react/src/types/nodes.ts

@@ -29,7 +29,14 @@ export type Node<
    */
   domAttributes?: Omit<
     HTMLAttributes<HTMLDivElement>,
-    'id' | 'style' | 'className' | 'draggable' | 'role' | 'aria-label' | keyof DOMAttributes<HTMLDivElement>
+    | 'id'
+    | 'style'
+    | 'className'
+    | 'draggable'
+    | 'role'
+    | 'aria-label'
+    | 'defaultValue'
+    | keyof DOMAttributes<HTMLDivElement>
   >;
 };
 

packages/svelte/src/lib/types/edges.ts

@@ -35,7 +35,7 @@ export type Edge<
    */
   domAttributes?: Omit<
     SVGAttributes<SVGGElement>,
-    'id' | 'style' | 'class' | 'role' | 'aria-label'
+    'id' | 'style' | 'class' | 'role' | 'aria-label' | 'defaultValue'
   >;
 };
 

packages/svelte/src/lib/types/nodes.ts

@@ -38,6 +38,7 @@ export type Node<
     | 'draggable'
     | 'role'
     | 'aria-label'
+    | 'defaultValue'
     | keyof DOMAttributes<HTMLDivElement>
   >;
 };