Merge pull request #5546 from xyflow/fix-minimap-all-hidden

Fix Minimap if all nodes are hidden

packages/svelte/src/lib/plugins/Minimap/Minimap.svelte

@@ -60,14 +60,11 @@
     width: store.width / store.viewport.zoom,
     height: store.height / store.viewport.zoom
   });
+
   let boundingRect = $derived(
-    store.nodeLookup.size > 0
-      ? getBoundsOfRects(
-          getInternalNodesBounds(store.nodeLookup, { filter: (n) => !n.hidden }),
-          viewBB
-        )
-      : viewBB
+    getBoundsOfRects(getInternalNodesBounds(store.nodeLookup, { filter: (n) => !n.hidden }), viewBB)
   );
+
   let scaledWidth = $derived(boundingRect.width / width);
   let scaledHeight = $derived(boundingRect.height / height);
   let viewScale = $derived(Math.max(scaledWidth, scaledHeight));
@@ -121,7 +118,7 @@
 
       {#each store.nodes as userNode (userNode.id)}
         {@const node = store.nodeLookup.get(userNode.id)}
-        {#if node && nodeHasDimensions(node)}
+        {#if node && nodeHasDimensions(node) && !node.hidden}
           {@const nodeDimesions = getNodeDimensions(node)}
           <MinimapNode
             x={node.internals.positionAbsolute.x}

packages/system/src/utils/graph.ts

@@ -241,20 +241,17 @@ export const getInternalNodesBounds = <NodeType extends InternalNodeBase | NodeD
   nodeLookup: Map<string, NodeType>,
   params: GetInternalNodesBoundsParams<NodeType> = {}
 ): Rect => {
-  if (nodeLookup.size === 0) {
-    return { x: 0, y: 0, width: 0, height: 0 };
-  }
-
   let box = { x: Infinity, y: Infinity, x2: -Infinity, y2: -Infinity };
+  let hasVisibleNodes = false;
 
   nodeLookup.forEach((node) => {
     if (params.filter === undefined || params.filter(node)) {
-      const nodeBox = nodeToBox(node as InternalNodeBase);
-      box = getBoundsOfBoxes(box, nodeBox);
+      box = getBoundsOfBoxes(box, nodeToBox(node as InternalNodeBase));
+      hasVisibleNodes = true;
     }
   });
 
-  return boxToRect(box);
+  return hasVisibleNodes ? boxToRect(box) : { x: 0, y: 0, width: 0, height: 0 };
 };
 
 export const getNodesInside = <NodeType extends NodeBase = NodeBase>(