From f4e9d9ad4c5799cd6b54f1e534216cae51b05afc Mon Sep 17 00:00:00 2001 From: Peter Date: Mon, 18 Sep 2023 17:36:53 +0200 Subject: [PATCH 1/2] fix(svelte) changed attribute names of className to class in MiniMap & Background plugins --- .../svelte/src/lib/plugins/Background/Background.svelte | 6 +++--- packages/svelte/src/lib/plugins/Background/types.ts | 2 +- packages/svelte/src/lib/plugins/Minimap/Minimap.svelte | 6 +++--- packages/svelte/src/lib/plugins/Minimap/types.ts | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/packages/svelte/src/lib/plugins/Background/Background.svelte b/packages/svelte/src/lib/plugins/Background/Background.svelte index 16d2f05d..5086c210 100644 --- a/packages/svelte/src/lib/plugins/Background/Background.svelte +++ b/packages/svelte/src/lib/plugins/Background/Background.svelte @@ -22,7 +22,7 @@ export let lineWidth: $$Props['lineWidth'] = 1; export let bgColor: $$Props['bgColor'] = undefined; export let patternColor: $$Props['patternColor'] = undefined; - export let patternClassName: $$Props['patternClassName'] = undefined; + export let patternClass: $$Props['patternClass'] = undefined; let className: $$Props['class'] = ''; export { className as class }; @@ -57,9 +57,9 @@ patternTransform={`translate(-${patternOffset[0]},-${patternOffset[1]})`} > {#if isDots} - + {:else} - + {/if} diff --git a/packages/svelte/src/lib/plugins/Background/types.ts b/packages/svelte/src/lib/plugins/Background/types.ts index d0935b4c..dd6a4d3c 100644 --- a/packages/svelte/src/lib/plugins/Background/types.ts +++ b/packages/svelte/src/lib/plugins/Background/types.ts @@ -7,7 +7,7 @@ export enum BackgroundVariant { export type BackgroundProps = { bgColor?: string; patternColor?: string; - patternClassName?: string; + patternClass?: string; class?: string; gap?: number | [number, number]; size?: number; diff --git a/packages/svelte/src/lib/plugins/Minimap/Minimap.svelte b/packages/svelte/src/lib/plugins/Minimap/Minimap.svelte index beb20d08..07ffde00 100644 --- a/packages/svelte/src/lib/plugins/Minimap/Minimap.svelte +++ b/packages/svelte/src/lib/plugins/Minimap/Minimap.svelte @@ -21,7 +21,7 @@ export let ariaLabel: $$Props['ariaLabel'] = 'Mini map'; export let nodeStrokeColor: $$Props['nodeStrokeColor'] = 'transparent'; export let nodeColor: $$Props['nodeColor'] = '#e2e2e2'; - export let nodeClassName: $$Props['nodeClassName'] = ''; + export let nodeClass: $$Props['nodeClass'] = ''; export let nodeBorderRadius: $$Props['nodeBorderRadius'] = 5; export let nodeStrokeWidth: $$Props['nodeStrokeWidth'] = 2; export let bgColor: $$Props['bgColor'] = undefined; @@ -53,7 +53,7 @@ const nodeColorFunc = getAttrFunction(nodeColor); const nodeStrokeColorFunc = getAttrFunction(nodeStrokeColor); - const nodeClassNameFunc = getAttrFunction(nodeClassName); + const nodeClassFunc = getAttrFunction(nodeClass); const shapeRendering = typeof window === 'undefined' || !!window.chrome ? 'crispEdges' : 'geometricPrecision'; const labelledBy = `svelte-flow__minimap-desc-${$flowId}`; @@ -126,7 +126,7 @@ strokeColor={nodeStrokeColorFunc(node)} strokeWidth={nodeStrokeWidth} {shapeRendering} - class={nodeClassNameFunc(node)} + class={nodeClassFunc(node)} /> {/if} {/each} diff --git a/packages/svelte/src/lib/plugins/Minimap/types.ts b/packages/svelte/src/lib/plugins/Minimap/types.ts index c141aac9..d39aab7a 100644 --- a/packages/svelte/src/lib/plugins/Minimap/types.ts +++ b/packages/svelte/src/lib/plugins/Minimap/types.ts @@ -8,7 +8,7 @@ export type MiniMapProps = { bgColor?: string; nodeColor?: string | GetMiniMapNodeAttribute; nodeStrokeColor?: string | GetMiniMapNodeAttribute; - nodeClassName?: string | GetMiniMapNodeAttribute; + nodeClass?: string | GetMiniMapNodeAttribute; nodeBorderRadius?: number; nodeStrokeWidth?: number; maskColor?: string; From 286753349e187ec41ea1dd7c2d5b62fb27ed1109 Mon Sep 17 00:00:00 2001 From: Peter Date: Mon, 18 Sep 2023 17:45:21 +0200 Subject: [PATCH 2/2] fix(svelte) changed attribute names from className to class in zoom and drag actions --- packages/svelte/src/lib/actions/drag/index.ts | 4 ++-- packages/svelte/src/lib/actions/zoom/index.ts | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/svelte/src/lib/actions/drag/index.ts b/packages/svelte/src/lib/actions/drag/index.ts index 692a1789..5a0d4436 100644 --- a/packages/svelte/src/lib/actions/drag/index.ts +++ b/packages/svelte/src/lib/actions/drag/index.ts @@ -6,7 +6,7 @@ import type { SvelteFlowStore } from '$lib/store/types'; type UseDragParams = { store: SvelteFlowStore; disabled?: boolean; - noDragClassName?: string; + noDragClass?: string; handleSelector?: string; nodeId?: string; isSelectable?: boolean; @@ -47,7 +47,7 @@ export default function drag(domNode: Element, params: UseDragParams) { dragInstance.update({ domNode, - noDragClassName: params.noDragClassName, + noDragClassName: params.noDragClass, handleSelector: params.handleSelector, nodeId: params.nodeId, isSelectable: params.isSelectable diff --git a/packages/svelte/src/lib/actions/zoom/index.ts b/packages/svelte/src/lib/actions/zoom/index.ts index ce579788..d85bc101 100644 --- a/packages/svelte/src/lib/actions/zoom/index.ts +++ b/packages/svelte/src/lib/actions/zoom/index.ts @@ -30,6 +30,8 @@ type ZoomParams = { panOnScrollMode: PanOnScrollMode; zoomActivationKeyPressed: boolean; preventScrolling: boolean; + // last two instances of 'classname' being used + // changing it to class would require object restructuring for use with panZoomInstance.update noPanClassName: string; noWheelClassName: string; userSelectionActive: boolean;