From e4233aa9b3fa83f5b3052c65c4a25514d8f288a1 Mon Sep 17 00:00:00 2001 From: moklick Date: Tue, 11 Aug 2020 19:18:48 +0200 Subject: [PATCH] fix(nodes): fire click event when node is selectable closes #424 --- src/components/Nodes/wrapNode.tsx | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/src/components/Nodes/wrapNode.tsx b/src/components/Nodes/wrapNode.tsx index e1ed6146..5f816bef 100644 --- a/src/components/Nodes/wrapNode.tsx +++ b/src/components/Nodes/wrapNode.tsx @@ -237,17 +237,18 @@ export default (NodeComponent: ComponentType) => { return (event: MouseEvent) => onContextMenu(event, node); }, [onContextMenu]); - const onSelectNodeHandler = useCallback(() => { - if (!isDraggable && isSelectable) { - setSelectedElements({ id: node.id, type: node.type } as Node); + const onSelectNodeHandler = useCallback( + (event: MouseEvent) => { + if (!isDraggable && isSelectable) { + setSelectedElements({ id: node.id, type: node.type } as Node); - if (onClick) { - return (event: MouseEvent) => onClick(event, node); + if (onClick) { + onClick(event, node); + } } - } - - return noop; - }, [isSelectable, isDraggable, node]); + }, + [isSelectable, isDraggable, node] + ); useEffect(() => { if (nodeElement.current) {