From ed1ead7b5a2680c7d549d6938c3ce3bb5022dbc6 Mon Sep 17 00:00:00 2001
From: peterkogo <peter@xyflow.com>
Date: Wed, 13 Nov 2024 18:17:42 +0100
Subject: [PATCH] fix linting, formatting

---
 .../svelte/src/lib/components/Handle/Handle.svelte     |  1 +
 .../lib/components/NodeSelection/NodeSelection.svelte  |  1 +
 .../src/lib/components/NodeWrapper/NodeWrapper.svelte  |  5 +++--
 .../SvelteFlowProvider/SvelteFlowProvider.svelte       |  5 +++--
 .../src/lib/components/SvelteFlowProvider/types.ts     |  4 +++-
 .../svelte/src/lib/components/nodes/GroupNode.svelte   |  1 +
 .../src/lib/container/SvelteFlow/SvelteFlow.svelte     |  1 -
 packages/svelte/src/lib/hooks/useNodesData.ts          |  2 +-
 packages/svelte/src/lib/plugins/Minimap/Minimap.svelte |  3 +--
 .../src/lib/plugins/NodeToolbar/NodeToolbar.svelte     |  1 +
 packages/svelte/src/lib/store/index.ts                 |  1 -
 packages/svelte/src/lib/store/utils.ts                 | 10 ++++++----
 12 files changed, 21 insertions(+), 14 deletions(-)

diff --git a/packages/svelte/src/lib/components/Handle/Handle.svelte b/packages/svelte/src/lib/components/Handle/Handle.svelte
index 04418c11..f0721989 100644
--- a/packages/svelte/src/lib/components/Handle/Handle.svelte
+++ b/packages/svelte/src/lib/components/Handle/Handle.svelte
@@ -110,6 +110,7 @@
   let prevConnections: Map<string, HandleConnection> | null = null;
   $effect.pre(() => {
     // connectionLookup is not reactive, so we use edges to get notified about updates
+    // eslint-disable-next-line @typescript-eslint/no-unused-expressions
     $edges;
     if (onconnect || ondisconnect) {
       let connections = $connectionLookup.get(`${nodeId}-${type}-${handleId}`);
diff --git a/packages/svelte/src/lib/components/NodeSelection/NodeSelection.svelte b/packages/svelte/src/lib/components/NodeSelection/NodeSelection.svelte
index 1fe47eee..f9e9cf88 100644
--- a/packages/svelte/src/lib/components/NodeSelection/NodeSelection.svelte
+++ b/packages/svelte/src/lib/components/NodeSelection/NodeSelection.svelte
@@ -20,6 +20,7 @@
 
   let bounds: Rect | null = $derived.by(() => {
     if ($selectionRectMode === 'nodes') {
+      // eslint-disable-next-line @typescript-eslint/no-unused-expressions
       $nodes;
       return getInternalNodesBounds($nodeLookup, { filter: (node) => !!node.selected });
     }
diff --git a/packages/svelte/src/lib/components/NodeWrapper/NodeWrapper.svelte b/packages/svelte/src/lib/components/NodeWrapper/NodeWrapper.svelte
index 9b5a625c..308d0167 100644
--- a/packages/svelte/src/lib/components/NodeWrapper/NodeWrapper.svelte
+++ b/packages/svelte/src/lib/components/NodeWrapper/NodeWrapper.svelte
@@ -1,6 +1,6 @@
 <script lang="ts">
   import { setContext, onDestroy } from 'svelte';
-  import { get, writable } from 'svelte/store';
+  import { get } from 'svelte/store';
   import cc from 'classcat';
   import { errorMessages, Position } from '@xyflow/system';
 
@@ -132,12 +132,13 @@
 
   // TODO: extract this part!
   $effect(() => {
-    // TODO: HOLY MOLY! changing the order of the initialized breaks effect subscriptions
+    /* eslint-disable @typescript-eslint/no-unused-expressions */
     if (resizeObserver && (!initialized || nodeRef !== prevNodeRef)) {
       prevNodeRef && resizeObserver.unobserve(prevNodeRef);
       nodeRef && resizeObserver.observe(nodeRef);
       prevNodeRef = nodeRef;
     }
+    /* eslint-enable @typescript-eslint/no-unused-expressions */
   });
 
   onDestroy(() => {
diff --git a/packages/svelte/src/lib/components/SvelteFlowProvider/SvelteFlowProvider.svelte b/packages/svelte/src/lib/components/SvelteFlowProvider/SvelteFlowProvider.svelte
index 1b64bbba..f533be1a 100644
--- a/packages/svelte/src/lib/components/SvelteFlowProvider/SvelteFlowProvider.svelte
+++ b/packages/svelte/src/lib/components/SvelteFlowProvider/SvelteFlowProvider.svelte
@@ -10,7 +10,8 @@
     initialWidth,
     initialHeight,
     nodeOrigin,
-    fitView
+    fitView,
+    children
   }: SvelteFlowProviderProps = $props();
 
   const store = createStore({
@@ -31,4 +32,4 @@
   });
 </script>
 
-<slot />
+{@render children?.()}
diff --git a/packages/svelte/src/lib/components/SvelteFlowProvider/types.ts b/packages/svelte/src/lib/components/SvelteFlowProvider/types.ts
index 39fa5350..427f498a 100644
--- a/packages/svelte/src/lib/components/SvelteFlowProvider/types.ts
+++ b/packages/svelte/src/lib/components/SvelteFlowProvider/types.ts
@@ -1,5 +1,6 @@
-import type { Edge, Node } from '$lib/types';
+import type { Snippet } from 'svelte';
 import type { NodeOrigin } from '@xyflow/system';
+import type { Edge, Node } from '$lib/types';
 
 export type SvelteFlowProviderProps = {
   initialNodes?: Node[];
@@ -8,4 +9,5 @@ export type SvelteFlowProviderProps = {
   initialHeight?: number;
   fitView?: boolean;
   nodeOrigin?: NodeOrigin;
+  children?: Snippet;
 };
diff --git a/packages/svelte/src/lib/components/nodes/GroupNode.svelte b/packages/svelte/src/lib/components/nodes/GroupNode.svelte
index 7f24ed1e..a5122b55 100644
--- a/packages/svelte/src/lib/components/nodes/GroupNode.svelte
+++ b/packages/svelte/src/lib/components/nodes/GroupNode.svelte
@@ -1,5 +1,6 @@
 <script lang="ts">
   import type { NodeProps } from '$lib/types';
 
+  // eslint-disable-next-line no-empty-pattern
   let {}: NodeProps = $props();
 </script>
diff --git a/packages/svelte/src/lib/container/SvelteFlow/SvelteFlow.svelte b/packages/svelte/src/lib/container/SvelteFlow/SvelteFlow.svelte
index c7904243..516e69cd 100644
--- a/packages/svelte/src/lib/container/SvelteFlow/SvelteFlow.svelte
+++ b/packages/svelte/src/lib/container/SvelteFlow/SvelteFlow.svelte
@@ -254,7 +254,6 @@
     <Pane {nodes} {edges} {onpaneclick} {onpanecontextmenu} {panOnDrag} {selectionOnDrag}>
       <ViewportComponent>
         <EdgeRenderer
-          on:edgeclick
           {onedgeclick}
           {onedgecontextmenu}
           {onedgemouseenter}
diff --git a/packages/svelte/src/lib/hooks/useNodesData.ts b/packages/svelte/src/lib/hooks/useNodesData.ts
index 2e8fba50..f582e874 100644
--- a/packages/svelte/src/lib/hooks/useNodesData.ts
+++ b/packages/svelte/src/lib/hooks/useNodesData.ts
@@ -42,7 +42,7 @@ export function useNodesData(nodeIds: any): any {
 
     if (!shallowNodeData(nextNodesData, prevNodesData) || initialRun) {
       prevNodesData = nextNodesData;
-      set(isArrayOfIds ? nextNodesData : nextNodesData[0] ?? null);
+      set(isArrayOfIds ? nextNodesData : (nextNodesData[0] ?? null));
       initialRun = false;
     }
   });
diff --git a/packages/svelte/src/lib/plugins/Minimap/Minimap.svelte b/packages/svelte/src/lib/plugins/Minimap/Minimap.svelte
index d2d93c92..84ecccf6 100644
--- a/packages/svelte/src/lib/plugins/Minimap/Minimap.svelte
+++ b/packages/svelte/src/lib/plugins/Minimap/Minimap.svelte
@@ -11,8 +11,7 @@
     getBoundsOfRects,
     getInternalNodesBounds,
     getNodeDimensions,
-    nodeHasDimensions,
-    type Rect
+    nodeHasDimensions
   } from '@xyflow/system';
 
   import { useStore } from '$lib/store';
diff --git a/packages/svelte/src/lib/plugins/NodeToolbar/NodeToolbar.svelte b/packages/svelte/src/lib/plugins/NodeToolbar/NodeToolbar.svelte
index 0e28e583..92ac6bdd 100644
--- a/packages/svelte/src/lib/plugins/NodeToolbar/NodeToolbar.svelte
+++ b/packages/svelte/src/lib/plugins/NodeToolbar/NodeToolbar.svelte
@@ -23,6 +23,7 @@
   const contextNodeId = getContext<string>('svelteflow__node_id');
 
   let toolbarNodes: InternalNode[] = $derived.by(() => {
+    // eslint-disable-next-line @typescript-eslint/no-unused-expressions
     $nodes;
     const nodeIds = Array.isArray(nodeId) ? nodeId : [nodeId ?? contextNodeId];
 
diff --git a/packages/svelte/src/lib/store/index.ts b/packages/svelte/src/lib/store/index.ts
index ac4ed5ec..94b6490c 100644
--- a/packages/svelte/src/lib/store/index.ts
+++ b/packages/svelte/src/lib/store/index.ts
@@ -3,7 +3,6 @@ import { derived, get, writable } from 'svelte/store';
 import {
   createMarkerIds,
   fitView as fitViewSystem,
-  getElementsToRemove,
   panBy as panBySystem,
   updateNodeInternals as updateNodeInternalsSystem,
   addEdge as addEdgeUtil,
diff --git a/packages/svelte/src/lib/store/utils.ts b/packages/svelte/src/lib/store/utils.ts
index 30af8f73..05fc45da 100644
--- a/packages/svelte/src/lib/store/utils.ts
+++ b/packages/svelte/src/lib/store/utils.ts
@@ -127,6 +127,8 @@ export type NodeStoreOptions = {
   elevateNodesOnSelect?: boolean;
 };
 
+type Update<T> = Writable<T>['update'];
+
 // we are creating a custom store for the internals nodes in order to update the zIndex and positionAbsolute.
 // The user only passes in relative positions, so we need to calculate the absolute positions based on the parent nodes.
 export const createNodesStore = (
@@ -142,7 +144,7 @@ export const createNodesStore = (
   setDefaultOptions: (opts: DefaultNodeOptions) => void;
   setOptions: (opts: NodeStoreOptions) => void;
 } => {
-  const { subscribe, set, update } = writable<Node[]>([]);
+  const { subscribe, set } = writable<Node[]>([]);
   let value = nodes;
   let defaults = {};
   let elevateNodesOnSelect = true;
@@ -163,7 +165,7 @@ export const createNodesStore = (
     return value;
   };
 
-  const _update: typeof update = (fn: (nds: Node[]) => Node[]) => _set(fn(value));
+  const _update: Update<Node[]> = (fn: (nds: Node[]) => Node[]) => _set(fn(value));
 
   const setDefaultOptions = (options: DefaultNodeOptions) => {
     defaults = options;
@@ -190,7 +192,7 @@ export const createEdgesStore = (
   edgeLookup: EdgeLookup<Edge>,
   defaultOptions?: DefaultEdgeOptions
 ): Writable<Edge[]> & { setDefaultOptions: (opts: DefaultEdgeOptions) => void } => {
-  const { subscribe, set, update } = writable<Edge[]>([]);
+  const { subscribe, set } = writable<Edge[]>([]);
   let value = edges;
   let defaults = defaultOptions || {};
 
@@ -203,7 +205,7 @@ export const createEdgesStore = (
     set(value);
   };
 
-  const _update: typeof update = (fn: (eds: Edge[]) => Edge[]) => _set(fn(value));
+  const _update: Update<Edge[]> = (fn: (eds: Edge[]) => Edge[]) => _set(fn(value));
 
   const setDefaultOptions = (options: DefaultEdgeOptions) => {
     defaults = options;