From 686fb87b35b407b9880b02b8c60f41e302f9f61f Mon Sep 17 00:00:00 2001 From: David Lounsbrough Date: Mon, 28 Nov 2022 13:05:27 -0600 Subject: [PATCH 1/4] Fix y position on minimap --- packages/minimap/src/MiniMap.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/minimap/src/MiniMap.tsx b/packages/minimap/src/MiniMap.tsx index 890df176..722f1423 100644 --- a/packages/minimap/src/MiniMap.tsx +++ b/packages/minimap/src/MiniMap.tsx @@ -173,7 +173,7 @@ function MiniMap({ Date: Mon, 28 Nov 2022 13:58:28 -0600 Subject: [PATCH 2/4] Add assertion to cover path that I fixed --- examples/vite-app/cypress/e2e/minimap.cy.ts | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/examples/vite-app/cypress/e2e/minimap.cy.ts b/examples/vite-app/cypress/e2e/minimap.cy.ts index d6cb7d46..46a5a819 100644 --- a/examples/vite-app/cypress/e2e/minimap.cy.ts +++ b/examples/vite-app/cypress/e2e/minimap.cy.ts @@ -35,17 +35,20 @@ describe('Minimap Testing', () => { }); it('changes node position', () => { - const xPosBeforeDrag = Cypress.$('.react-flow__minimap-node:first').attr('x'); - const yPosBeforeDrag = Cypress.$('.react-flow__minimap-node:first').attr('y'); + const minimapNode = Cypress.$('.react-flow__minimap-node:first'); + + const xPosBeforeDrag = Number(minimapNode.attr('x')); + const yPosBeforeDrag = Number(minimapNode.attr('y')); cy.drag('.react-flow__node:first', { x: 500, y: 25 }) .wait(100) .then(() => { - const xPosAfterDrag = Cypress.$('.react-flow__minimap-node:first').attr('x'); - const yPosAfterDrag = Cypress.$('.react-flow__minimap-node:first').attr('y'); + const xPosAfterDrag = Number(minimapNode.attr('x')); + const yPosAfterDrag = Number(minimapNode.attr('y')); - expect(xPosBeforeDrag).to.not.equal(xPosAfterDrag); - expect(yPosBeforeDrag).to.not.equal(yPosAfterDrag); + expect(xPosAfterDrag).not.to.equal(xPosBeforeDrag); + expect(yPosAfterDrag).not.to.equal(yPosBeforeDrag); + expect(xPosAfterDrag - xPosBeforeDrag).to.be.greaterThan(yPosAfterDrag - yPosBeforeDrag); }); }); From 7ece618d94b76183c1ecd45b16f6ab168168351b Mon Sep 17 00:00:00 2001 From: moklick Date: Mon, 28 Nov 2022 21:13:27 +0100 Subject: [PATCH 3/4] chore(changeset): add --- .changeset/twelve-lamps-fix.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .changeset/twelve-lamps-fix.md diff --git a/.changeset/twelve-lamps-fix.md b/.changeset/twelve-lamps-fix.md new file mode 100644 index 00000000..3dc84a16 --- /dev/null +++ b/.changeset/twelve-lamps-fix.md @@ -0,0 +1,6 @@ +--- +'@reactflow/minimap': patch +'reactflow': patch +--- + +Fix minimap node position From 780710da24307346b31114475d124ebeba5929ff Mon Sep 17 00:00:00 2001 From: moklick Date: Mon, 28 Nov 2022 21:15:17 +0100 Subject: [PATCH 4/4] chore(packages): bump --- .changeset/twelve-lamps-fix.md | 6 ------ examples/vite-app/package.json | 2 +- packages/minimap/CHANGELOG.md | 6 ++++++ packages/minimap/package.json | 2 +- packages/reactflow/CHANGELOG.md | 9 +++++++++ packages/reactflow/package.json | 2 +- 6 files changed, 18 insertions(+), 9 deletions(-) delete mode 100644 .changeset/twelve-lamps-fix.md diff --git a/.changeset/twelve-lamps-fix.md b/.changeset/twelve-lamps-fix.md deleted file mode 100644 index 3dc84a16..00000000 --- a/.changeset/twelve-lamps-fix.md +++ /dev/null @@ -1,6 +0,0 @@ ---- -'@reactflow/minimap': patch -'reactflow': patch ---- - -Fix minimap node position diff --git a/examples/vite-app/package.json b/examples/vite-app/package.json index cf31055e..677f7289 100644 --- a/examples/vite-app/package.json +++ b/examples/vite-app/package.json @@ -1,7 +1,7 @@ { "name": "@reactflow/examples", "private": true, - "version": "0.0.1", + "version": "0.0.0", "type": "module", "scripts": { "dev": "vite --port 3000 --open", diff --git a/packages/minimap/CHANGELOG.md b/packages/minimap/CHANGELOG.md index 36a8f029..bcefc201 100644 --- a/packages/minimap/CHANGELOG.md +++ b/packages/minimap/CHANGELOG.md @@ -1,5 +1,11 @@ # @reactflow/minimap +## 11.2.2 + +### Patch Changes + +- [`7ece618d`](https://github.com/wbkd/react-flow/commit/7ece618d94b76183c1ecd45b16f6ab168168351b) Thanks [@](https://github.com/lounsbrough)! - Fix minimap node position + ## 11.2.1 ### Patch Changes diff --git a/packages/minimap/package.json b/packages/minimap/package.json index e2b66d07..d6dc1331 100644 --- a/packages/minimap/package.json +++ b/packages/minimap/package.json @@ -1,6 +1,6 @@ { "name": "@reactflow/minimap", - "version": "11.2.1", + "version": "11.2.2", "description": "Minimap component for React Flow.", "keywords": [ "react", diff --git a/packages/reactflow/CHANGELOG.md b/packages/reactflow/CHANGELOG.md index ea6e9a15..165c85c6 100644 --- a/packages/reactflow/CHANGELOG.md +++ b/packages/reactflow/CHANGELOG.md @@ -1,5 +1,14 @@ # reactflow +## 11.3.2 + +### Patch Changes + +- [`7ece618d`](https://github.com/wbkd/react-flow/commit/7ece618d94b76183c1ecd45b16f6ab168168351b) Thanks [@](https://github.com/lounsbrough)! - Fix minimap node position + +- Updated dependencies [[`7ece618d`](https://github.com/wbkd/react-flow/commit/7ece618d94b76183c1ecd45b16f6ab168168351b)]: + - @reactflow/minimap@11.2.2 + ## 11.3.1 ### Patch Changes diff --git a/packages/reactflow/package.json b/packages/reactflow/package.json index 9449f8ba..f84f948a 100644 --- a/packages/reactflow/package.json +++ b/packages/reactflow/package.json @@ -1,6 +1,6 @@ { "name": "reactflow", - "version": "11.3.1", + "version": "11.3.2", "description": "A highly customizable React library for building node-based editors and interactive flow charts", "keywords": [ "react",