refactor(props): remove onConnectStop #2299

packages/core/src/components/Handle/handler.ts

@@ -160,7 +160,6 @@ export function handleMouseDown({
   }
 
   function onMouseUp(event: MouseEvent) {
-    const { onConnectStop, onConnectEnd } = getState();
     const { connection, isValid } = checkElementBelowIsValid(
       event,
       connectionMode,
@@ -171,13 +170,11 @@ export function handleMouseDown({
       doc
     );
 
-    onConnectStop?.(event);
-
     if (isValid) {
       onConnect?.(connection);
     }
 
-    onConnectEnd?.(event);
+    getState().onConnectEnd?.(event);
 
     if (elementEdgeUpdaterType && onEdgeUpdateEnd) {
       onEdgeUpdateEnd(event);

packages/core/src/components/Handle/index.tsx

@@ -74,7 +74,7 @@ const Handle = forwardRef<HTMLDivElement, HandleComponentProps>(
     };
 
     const onClick = (event: React.MouseEvent) => {
-      const { onClickConnectStart, onClickConnectStop, onClickConnectEnd, connectionMode } = store.getState();
+      const { onClickConnectStart, onClickConnectEnd, connectionMode } = store.getState();
       if (!connectionStartHandle) {
         onClickConnectStart?.(event, { nodeId, handleId, handleType: type });
         store.setState({ connectionStartHandle: { nodeId, type, handleId } });
@@ -92,8 +92,6 @@ const Handle = forwardRef<HTMLDivElement, HandleComponentProps>(
         doc
       );
 
-      onClickConnectStop?.(event as unknown as MouseEvent);
-
       if (isValid) {
         onConnectExtended(connection);
       }

packages/core/src/components/StoreUpdater/index.tsx

@@ -13,10 +13,8 @@ type StoreUpdaterProps = Pick<
   | 'defaultEdges'
   | 'onConnect'
   | 'onConnectStart'
-  | 'onConnectStop'
   | 'onConnectEnd'
   | 'onClickConnectStart'
-  | 'onClickConnectStop'
   | 'onClickConnectEnd'
   | 'nodesDraggable'
   | 'nodesConnectable'
@@ -79,10 +77,8 @@ const StoreUpdater = ({
   defaultEdges,
   onConnect,
   onConnectStart,
-  onConnectStop,
   onConnectEnd,
   onClickConnectStart,
-  onClickConnectStop,
   onClickConnectEnd,
   nodesDraggable,
   nodesConnectable,
@@ -133,10 +129,8 @@ const StoreUpdater = ({
   useDirectStoreUpdater('connectionMode', connectionMode, store.setState);
   useDirectStoreUpdater('onConnect', onConnect, store.setState);
   useDirectStoreUpdater('onConnectStart', onConnectStart, store.setState);
-  useDirectStoreUpdater('onConnectStop', onConnectStop, store.setState);
   useDirectStoreUpdater('onConnectEnd', onConnectEnd, store.setState);
   useDirectStoreUpdater('onClickConnectStart', onClickConnectStart, store.setState);
-  useDirectStoreUpdater('onClickConnectStop', onClickConnectStop, store.setState);
   useDirectStoreUpdater('onClickConnectEnd', onClickConnectEnd, store.setState);
   useDirectStoreUpdater('nodesDraggable', nodesDraggable, store.setState);
   useDirectStoreUpdater('nodesConnectable', nodesConnectable, store.setState);