From 2047dbab1cde7fad1cad4bade46ac51bd97b5cc0 Mon Sep 17 00:00:00 2001 From: peterkogo Date: Mon, 15 Sep 2025 15:41:48 +0200 Subject: [PATCH 1/3] initial try --- packages/system/src/utils/edges/general.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/system/src/utils/edges/general.ts b/packages/system/src/utils/edges/general.ts index c88c7272..af6ee77b 100644 --- a/packages/system/src/utils/edges/general.ts +++ b/packages/system/src/utils/edges/general.ts @@ -45,12 +45,12 @@ export function getElevatedEdgeZIndex({ if (zIndex !== undefined) { return zIndex; } - const edgeZ = elevateOnSelect && selected ? 1000 : 0; + // const edgeZ = elevateOnSelect && (sourceNode.selected || targetNode.selected || selected) ? 1000 : 0; const nodeZ = Math.max( - sourceNode.parentId ? sourceNode.internals.z : 0, - targetNode.parentId ? targetNode.internals.z : 0 + sourceNode.parentId || (elevateOnSelect && sourceNode.selected) ? sourceNode.internals.z : 0, + targetNode.parentId || (elevateOnSelect && targetNode.selected) ? targetNode.internals.z : 0 ); return edgeZ + nodeZ; From bcdc21647190830a45c2f479ea6f07f053931ebc Mon Sep 17 00:00:00 2001 From: peterkogo Date: Mon, 15 Sep 2025 16:51:29 +0200 Subject: [PATCH 2/3] elevate edges if the connected nodes are selected --- packages/system/src/utils/edges/general.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/system/src/utils/edges/general.ts b/packages/system/src/utils/edges/general.ts index af6ee77b..58139394 100644 --- a/packages/system/src/utils/edges/general.ts +++ b/packages/system/src/utils/edges/general.ts @@ -46,7 +46,6 @@ export function getElevatedEdgeZIndex({ return zIndex; } const edgeZ = elevateOnSelect && selected ? 1000 : 0; - // const edgeZ = elevateOnSelect && (sourceNode.selected || targetNode.selected || selected) ? 1000 : 0; const nodeZ = Math.max( sourceNode.parentId || (elevateOnSelect && sourceNode.selected) ? sourceNode.internals.z : 0, From d891e5ff106c6202f69a9b14d261294cc29bbec7 Mon Sep 17 00:00:00 2001 From: peterkogo Date: Mon, 15 Sep 2025 16:52:37 +0200 Subject: [PATCH 3/3] chore(changeset) --- .changeset/purple-toys-fly.md | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 .changeset/purple-toys-fly.md diff --git a/.changeset/purple-toys-fly.md b/.changeset/purple-toys-fly.md new file mode 100644 index 00000000..0f165410 --- /dev/null +++ b/.changeset/purple-toys-fly.md @@ -0,0 +1,7 @@ +--- +'@xyflow/system': patch +'@xyflow/react': patch +'@xyflow/svelte': patch +--- + +Fix regression: elevate edges if connected nodes are selected