chore(xyhandle): cleanup

packages/react/src/store/index.ts

@@ -190,16 +190,16 @@ const createStore = ({
             type: 'position',
             position: expandParent
               ? {
-                x: Math.max(0, dragItem.position.x),
+                  x: Math.max(0, dragItem.position.x),
-                y: Math.max(0, dragItem.position.y),
+                  y: Math.max(0, dragItem.position.y),
-              }
+                }
               : dragItem.position,
             dragging,
           };
 
-          if (node && connection.inProgress && connection.fromNode.id == node.id) {
+          if (node && connection.inProgress && connection.fromNode.id === node.id) {
             const updatedFrom = getHandlePosition(node, connection.fromHandle, Position.Left, true);
-            updateConnection({...connection,from: updatedFrom})
+            updateConnection({ ...connection, from: updatedFrom });
           }
 
           if (expandParent && node.parentId) {

packages/svelte/src/lib/store/index.ts

@@ -54,11 +54,13 @@ export function createStore<NodeType extends Node = Node, EdgeType extends Edge
   const updateNodePositions: UpdateNodePositions = (nodeDragItems, dragging = false) => {
     store.nodes = store.nodes.map((node) => {
       if (store.connection.inProgress && store.connection.fromNode.id === node.id) {
-        
+        const internalNode = store.nodeLookup.get(node.id);
-        store.connection = {
+        if (internalNode) {
-          ...store.connection,
+          store.connection = {
-          from: getHandlePosition(store.nodeLookup.get(node.id), store.connection.fromHandle, Position.Left, true)
+            ...store.connection,
-        };
+            from: getHandlePosition(internalNode, store.connection.fromHandle, Position.Left, true)
+          };
+        }
       }
       const dragItem = nodeDragItems.get(node.id);
       return dragItem ? { ...node, position: dragItem.position, dragging } : node;

packages/system/src/xyhandle/XYHandle.ts

@@ -93,8 +93,8 @@ function onPointerDown(
     position: fromHandleInternal.position,
   };
 
-  const fromNodeInternal = nodeLookup.get(nodeId)!;
+  const fromInternalNode = nodeLookup.get(nodeId)!;
-  const from = getHandlePosition(fromNodeInternal, fromHandle, Position.Left, true);
+  const from = getHandlePosition(fromInternalNode, fromHandle, Position.Left, true);
 
   let previousConnection: ConnectionInProgress = {
     inProgress: true,
@@ -103,7 +103,7 @@ function onPointerDown(
     from,
     fromHandle,
     fromPosition: fromHandle.position,
-    fromNode: fromNodeInternal,
+    fromNode: fromInternalNode,
 
     to: position,
     toHandle: null,
@@ -172,8 +172,10 @@ function onPointerDown(
     connection = result.connection;
     isValid = isConnectionValid(!!closestHandle, result.isValid);
 
-    const fromNodeInternal = nodeLookup.get(nodeId)!;
+    const fromInternalNode = nodeLookup.get(nodeId);
-    const from = getHandlePosition(fromNodeInternal, fromHandle, Position.Left, true); 
+    const from = fromInternalNode
+      ? getHandlePosition(fromInternalNode, fromHandle, Position.Left, true)
+      : previousConnection.from;
 
     const newConnection: ConnectionInProgress = {
       ...previousConnection,