From 06ae32d9825d54e7829b64616d9e3f4f1d8808d9 Mon Sep 17 00:00:00 2001 From: moklick Date: Mon, 6 Mar 2023 15:31:44 +0100 Subject: [PATCH 1/3] fix(handles): check if handle is connectable closes #2869 --- packages/core/src/components/Handle/utils.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/core/src/components/Handle/utils.ts b/packages/core/src/components/Handle/utils.ts index 58263781..bfd181e1 100644 --- a/packages/core/src/components/Handle/utils.ts +++ b/packages/core/src/components/Handle/utils.ts @@ -104,9 +104,10 @@ export function isValidHandle( // in strict mode we don't allow target to target or source to source connections const isValid = - connectionMode === ConnectionMode.Strict + handleToCheck.classList.contains('connectable') && + (connectionMode === ConnectionMode.Strict ? (isTarget && handleType === 'source') || (!isTarget && handleType === 'target') - : handleNodeId !== fromNodeId || handleId !== fromHandleId; + : handleNodeId !== fromNodeId || handleId !== fromHandleId); if (isValid) { result.isValid = isValidConnection(connection); From 8f080bd5e0e7e6c71f51eee9c9f2bc4b25182861 Mon Sep 17 00:00:00 2001 From: moklick Date: Mon, 6 Mar 2023 15:32:46 +0100 Subject: [PATCH 2/3] chore(chnageset): add --- .changeset/real-cats-sneeze.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/real-cats-sneeze.md diff --git a/.changeset/real-cats-sneeze.md b/.changeset/real-cats-sneeze.md new file mode 100644 index 00000000..2b6c0dcd --- /dev/null +++ b/.changeset/real-cats-sneeze.md @@ -0,0 +1,5 @@ +--- +'@reactflow/core': major +--- + +fix: check if handle is connectable From e3eb256c772707c18c7d56488f486413015156d9 Mon Sep 17 00:00:00 2001 From: moklick Date: Mon, 6 Mar 2023 15:33:32 +0100 Subject: [PATCH 3/3] chore(changesets): adjust --- .changeset/rare-points-change.md | 2 +- .changeset/real-cats-sneeze.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.changeset/rare-points-change.md b/.changeset/rare-points-change.md index 9ce10e25..28a38179 100644 --- a/.changeset/rare-points-change.md +++ b/.changeset/rare-points-change.md @@ -1,5 +1,5 @@ --- -'@reactflow/core': major +'@reactflow/core': patch --- track modifier keys on useKeypress diff --git a/.changeset/real-cats-sneeze.md b/.changeset/real-cats-sneeze.md index 2b6c0dcd..3f8f02bc 100644 --- a/.changeset/real-cats-sneeze.md +++ b/.changeset/real-cats-sneeze.md @@ -1,5 +1,5 @@ --- -'@reactflow/core': major +'@reactflow/core': patch --- fix: check if handle is connectable