From f722e2f0a3e5eea1bbdc9620f2c26e3d83b4466c Mon Sep 17 00:00:00 2001
From: moklick <info@moritzklack.com>
Date: Tue, 9 Jul 2024 11:21:31 +0200
Subject: [PATCH] fix(onNodeDragStop): nodes are set to dragging=false

---
 packages/react/CHANGELOG.md          | 1 +
 packages/react/src/store/index.ts    | 1 -
 packages/svelte/CHANGELOG.md         | 1 +
 packages/system/src/xydrag/XYDrag.ts | 1 +
 packages/system/src/xydrag/utils.ts  | 4 ++++
 5 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/packages/react/CHANGELOG.md b/packages/react/CHANGELOG.md
index 3c52df40..027b0d49 100644
--- a/packages/react/CHANGELOG.md
+++ b/packages/react/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## 12.0.0-next.28
 
 - add `paneDistanceClick` prop (max distance between mousedown/up that will trigger a click)
+- returned nodes in `onNodeDragStop` are set to `dragging=false` 
 
 ## 12.0.0-next.27
 
diff --git a/packages/react/src/store/index.ts b/packages/react/src/store/index.ts
index 3d3eab93..9d101191 100644
--- a/packages/react/src/store/index.ts
+++ b/packages/react/src/store/index.ts
@@ -134,7 +134,6 @@ const createStore = ({
         const changes = [];
 
         for (const [id, dragItem] of nodeDragItems) {
-          // @todo add expandParent to drag item so that we can get rid of the look up here
           const change: NodeChange = {
             id,
             type: 'position',
diff --git a/packages/svelte/CHANGELOG.md b/packages/svelte/CHANGELOG.md
index d41c15dd..7f53295b 100644
--- a/packages/svelte/CHANGELOG.md
+++ b/packages/svelte/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## 0.1.10
 
 - add `paneDistanceClick` prop (max distance between mousedown/up that will trigger a click)
+- returned nodes in `on:nodedragstop` are set to `dragging=false` 
 
 ## 0.1.9
 
diff --git a/packages/system/src/xydrag/XYDrag.ts b/packages/system/src/xydrag/XYDrag.ts
index 54489a00..d03f729c 100644
--- a/packages/system/src/xydrag/XYDrag.ts
+++ b/packages/system/src/xydrag/XYDrag.ts
@@ -332,6 +332,7 @@ export function XYDrag<OnNodeDrag extends (e: any, nodes: any, node: any) => voi
               nodeId,
               dragItems,
               nodeLookup,
+              dragging: false,
             });
 
             onDragStop?.(event.sourceEvent as MouseEvent, dragItems, currentNode, currentNodes);
diff --git a/packages/system/src/xydrag/utils.ts b/packages/system/src/xydrag/utils.ts
index ee8326ff..a668746a 100644
--- a/packages/system/src/xydrag/utils.ts
+++ b/packages/system/src/xydrag/utils.ts
@@ -81,10 +81,12 @@ export function getEventHandlerParams<NodeType extends InternalNodeBase>({
   nodeId,
   dragItems,
   nodeLookup,
+  dragging = true,
 }: {
   nodeId?: string;
   dragItems: Map<string, NodeDragItem>;
   nodeLookup: Map<string, NodeType>;
+  dragging?: boolean;
 }): [NodeBase, NodeBase[]] {
   const nodesFromDragItems: NodeBase[] = [];
 
@@ -95,6 +97,7 @@ export function getEventHandlerParams<NodeType extends InternalNodeBase>({
       nodesFromDragItems.push({
         ...node,
         position: dragItem.position,
+        dragging,
       });
     }
   }
@@ -109,6 +112,7 @@ export function getEventHandlerParams<NodeType extends InternalNodeBase>({
     {
       ...node,
       position: dragItems.get(nodeId)?.position || node.position,
+      dragging,
     },
     nodesFromDragItems,
   ];