From a1cc9da535aea7c3907e4eaf7fdebfc5701bcf58 Mon Sep 17 00:00:00 2001 From: Richard Schulz Date: Tue, 29 Nov 2022 17:24:34 +0100 Subject: [PATCH 1/3] Add generic support for the type property on the Node type --- packages/core/src/types/nodes.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/core/src/types/nodes.ts b/packages/core/src/types/nodes.ts index 39d8755c..4d4c66b1 100644 --- a/packages/core/src/types/nodes.ts +++ b/packages/core/src/types/nodes.ts @@ -5,11 +5,11 @@ import { internalsSymbol } from '../utils'; import type { XYPosition, Position, CoordinateExtent, HandleElement } from '.'; // interface for the user node items -export type Node = { +export type Node = { id: string; position: XYPosition; data: T; - type?: string; + type: U; style?: CSSProperties; className?: string; sourcePosition?: Position; From 2aef1ab4dace002cda6cbe22fb61d848153ac9d8 Mon Sep 17 00:00:00 2001 From: moklick Date: Wed, 25 Jan 2023 14:15:41 +0100 Subject: [PATCH 2/3] chore(types): make node type optional again --- packages/core/src/types/nodes.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core/src/types/nodes.ts b/packages/core/src/types/nodes.ts index 4d4c66b1..55824177 100644 --- a/packages/core/src/types/nodes.ts +++ b/packages/core/src/types/nodes.ts @@ -9,7 +9,7 @@ export type Node = { id: string; position: XYPosition; data: T; - type: U; + type?: U; style?: CSSProperties; className?: string; sourcePosition?: Position; From 4c516882d2bbf426c1832a53ad40763cc1abef92 Mon Sep 17 00:00:00 2001 From: moklick Date: Wed, 25 Jan 2023 14:17:42 +0100 Subject: [PATCH 3/3] chore(changeset): add --- .changeset/twenty-turkeys-rhyme.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/twenty-turkeys-rhyme.md diff --git a/.changeset/twenty-turkeys-rhyme.md b/.changeset/twenty-turkeys-rhyme.md new file mode 100644 index 00000000..2a5e909d --- /dev/null +++ b/.changeset/twenty-turkeys-rhyme.md @@ -0,0 +1,5 @@ +--- +'@reactflow/core': patch +--- + +Types: improve typing for node type