Commit Graph
340 Commits
Author SHA1 Message Date
Luis CarlosandGitHub abeb4086d3 fix: Correct parent node lookup in evaluateAbsolutePosition
### Summary

This PR fixes a bug in the `evaluateAbsolutePosition` function where the incorrect parent node was being retrieved from the `nodeLookup` in each iteration of the while loop.

### Changes

- Modified the line `const parent = nodeLookup.get(parentId);` to `const parent = nodeLookup.get(nextParentId);`.

### Reason

The original implementation used `parentId` to look up the parent node, which did not change within the loop. This resulted in the same parent node being used for each iteration, leading to incorrect calculations of the absolute position. By using `nextParentId`, we ensure that the correct parent node is retrieved and used in each iteration.
2024-06-05 09:29:48 -01:00
moklick 3cc14e8ee5 refactor(nodes): add parentId to NodeProps closes #4061 2024-06-03 17:23:46 +02:00
peterkogo 403aa8f5da exposed selectable, deletable, draggable to custom nodes & edges 2024-06-03 10:48:05 +02:00
peterkogo e81194d58a Include origin directly in positionAbsolute of node 2024-05-22 15:38:08 +02:00
moklick 02250e972d chore(packages): bump 2024-05-08 22:36:26 +02:00
moklick ccadb043c3 refactor(system): mutate internal node instead of creating a new one 2024-05-08 22:20:13 +02:00
moklick a364a93082 feat(react): add warning when styles not loaded #4047 2024-05-07 18:25:04 +02:00
moklick 2b0d75ddaa refactor(types): only export HandleProps but not HandleComponentProps 2024-05-07 16:22:26 +02:00
moklick 5f3dbbbade chore(versions): bump 2024-05-02 18:05:38 +02:00
moklick ce9ce1db0b fix(system): return user nodes in node drag/click handlers 2024-05-02 17:40:48 +02:00
moklick f2f2c3cc2e feat(svelte): add fitViewOptions for Controls closes #4201 2024-05-02 15:36:42 +02:00
moklick 170ef688a8 chore(react): changelog 2024-04-30 17:52:06 +02:00
Moritz KlackandGitHub b67ff60d5c Merge pull request #4226 from DenizUgur/update-node-internals-typing
fix typing for `UpdateNodeInternals`
2024-04-30 17:48:35 +02:00
moklick d1b50707ff fix(system): pinch zoom on windows #3759 2024-04-30 16:42:33 +02:00
moklick a9dfd45b4f fix(system): dont break touch pan with panOnDrag is an array 2024-04-30 16:41:13 +02:00
DenizUgur eec2a6923d fix typing for UpdateNodeInternals 2024-04-29 12:43:10 -07:00
moklick 7501eace79 fix(react): default node updates closes #4202 2024-04-29 13:35:58 +02:00
moklick d0e07b2e04 chore(packages): bump 2024-04-22 15:06:05 +02:00
moklick 7e8bcd8825 refactor(react): add setAttributes for dimension changes 2024-04-22 14:51:23 +02:00
moklick b6f458fc5a chore(utils): cleanup 2024-04-18 09:57:30 +02:00
moklick 6c30686127 refactor(utils): cleanup getPositionWithOrigin 2024-04-18 09:17:51 +02:00
Moritz KlackandGitHub 356737d5be Merge pull request #4176 from tonyf/tonyf/node-resizer
[v12] call `onEnd` in `XYResizer`'s `end` drag event handler
2024-04-18 09:05:45 +02:00
Tony Francis 6494c3fac4 call onEnd in end drag event hanlder in XYResizer 2024-04-18 02:52:14 -04:00
moklick 12c081a62e chore(useReactFlow): cleanup 2024-04-17 13:50:52 +02:00
moklick 6bab47fcb7 refactor(node-selection): cleanup 2024-04-17 12:34:31 +02:00
moklick eafb3c5e34 refactor(xydrag): cleanup 2024-04-16 18:31:08 +02:00
moklick 5db4bd4dfd refactor(xydrag): cleanup 2024-04-16 18:25:31 +02:00
moklick 3348194dea refactor(xydrag): cleanup 2024-04-16 18:22:07 +02:00
moklick f242494b29 Merge branch 'next' into refactor/xy-drag-use-map 2024-04-16 18:00:32 +02:00
Moritz KlackandGitHub e584b6810e Merge pull request #4146 from xyflow/internal-fix-resizer
Fix NodeResizer, handleParentExpand & add parentLookup
2024-04-16 17:52:29 +02:00
moklick 2102c17108 refactor(xydrag): use map for drag items 2024-04-16 17:09:51 +02:00
peterkogo 27987006f3 renamed newPosition to nextPosition, removed comment 2024-04-16 16:58:56 +02:00
peterkogo aad6de5359 simplified handleExpandParent, removed isParent, improved some functions 2024-04-16 16:54:38 +02:00
peterkogo 714d30b63f fixed bug with expanding parent, made adjustments to evaluateNodePosition 2024-04-16 13:19:44 +02:00
Moritz KlackandGitHub b2b23a9cd4 Merge pull request #4143 from xyflow/fix-minimap-panning
Minimap: removed usage of movementX, movementY and instead calculate delta manually
2024-04-16 11:18:45 +02:00
peterkogo 81bdaf6b68 prevent falsely adjusting currently dragged item on parentExpand 2024-04-15 17:31:48 +02:00
peterkogo 87086e9997 added correct expandParent offset of children 2024-04-15 17:23:14 +02:00
peterkogo ccf6578824 added parentLookup 2024-04-15 17:03:03 +02:00
peterkogo c5f394e1f7 use evaluateNodePosition for parentExpand 2024-04-15 15:58:25 +02:00
peterkogo f0677408ac Merge branch 'next' into internal-fix-resizer 2024-04-15 13:23:47 +02:00
moklick 8a56311e52 fix(intersection-helpers): use correct positions closes #4138 2024-04-15 13:18:57 +02:00
peterkogo 979fe7d565 broken parent expand on resize but almost there 2024-04-11 18:34:17 +02:00
peterkogo 05ac4ef9db Merge branch 'next' into internal-fix-resizer 2024-04-11 17:31:10 +02:00
peterkogo 256fad3053 removed consolelog 2024-04-11 15:17:36 +02:00
peterkogo 72d775b8eb simplified resize events 2024-04-11 15:14:39 +02:00
moklick 8897c2a9ff chore(packages): bump 2024-04-11 13:33:06 +02:00
peterkogo 6edd5121b6 renamed now to current 2024-04-11 12:41:27 +02:00
peterkogo 1c74eb1d94 removed usage of movementX and movementY and calculate delta by hand 2024-04-11 12:34:51 +02:00
moklick 4fa3a87241 refactor(updates): only trigger dim updates when dim changed 2024-04-11 12:31:14 +02:00
moklick 63aa0dd713 fix(viewport): set direction=ltr for react flow wrapper 2024-04-11 12:04:13 +02:00