alighasami
3d5eaf9445
Security: Sync from Public / sync-from-public (push) Has been cancelled
Test: Benchmark Nightly / build (push) Has been cancelled
Test: Benchmark Nightly / Notify Cats on failure (push) Has been cancelled
CI: Python / Checks (push) Has been cancelled
Test: Evals Python / Workflow Comparison Python (push) Has been cancelled
Util: Check Docs URLs / check-docs-urls (push) Has been cancelled
Test: Visual Storybook / Cloudflare Pages (push) Has been cancelled
Test: E2E Performance / build-and-test-performance (push) Has been cancelled
Test: Workflows Nightly / Run Workflow Tests (push) Has been cancelled
Util: Cleanup CI Docker Images / Delete stale CI images (push) Has been cancelled
Test: Benchmark Destroy Env / build (push) Has been cancelled
Util: Update Node Popularity / update-popularity (push) Has been cancelled
Test: E2E Coverage Weekly / Coverage Tests (push) Has been cancelled
30 lines
1.4 KiB
Markdown
30 lines
1.4 KiB
Markdown
# AWS ELB Test Implementation Notes
|
|
|
|
This document explains intentional test data adjustments made to match the current implementation behavior.
|
|
|
|
## Known Implementation Issues
|
|
|
|
### 1. Typo in Remove Listener Certificate Operation
|
|
|
|
**File**: `remove-listener-certificate.workflow.json`
|
|
**Issue**: The response contains `"sucess": true` instead of `"success": true`
|
|
**Root Cause**: Spelling error in the node implementation
|
|
**Test Adjustment**: The pinData uses the misspelled version to match actual output
|
|
**TODO**: Fix the typo in the AWS ELB node implementation and update test accordingly
|
|
|
|
### 2. Boolean Values Returned as Strings
|
|
|
|
**File**: `get-many-listener-certificates-all.workflow.json`
|
|
**Issue**: Boolean values like `IsDefault` are returned as strings ("true"/"false") instead of actual booleans
|
|
**Root Cause**: AWS API response parsing returns string values rather than converting to boolean types
|
|
**Test Adjustment**: The pinData uses string values ("true"/"false") instead of boolean values (true/false)
|
|
**Note**: This reflects how the AWS API response is actually parsed and returned by the node
|
|
|
|
## Test Data Maintenance
|
|
|
|
When updating these test files:
|
|
|
|
1. Verify the actual node implementation output before changing expected results
|
|
2. If implementation bugs are fixed, update both the node code and corresponding test data
|
|
3. Consider backward compatibility when making changes that affect output format
|