alighasami/vue-flow
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(core): don't set user selection flags on pointer down (#1600)

Browse Source 
* chore(core): remove deprecation of `removeSelectedElements`

Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com>

* fix(core): don't set user selection flags on pointer down

Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com>

* fix(core): prevent panning on drag when selection is active

Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com>

* chore(changeset): add

Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com>

---------

Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com>
This commit is contained in:
Braks
2024-08-27 21:55:38 +02:00
parent 9c003d4353
commit eb12bdc56f
4 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/lemon-files-fold.md Normal file
View File

@@ -0,0 +1,5 @@
---
"@vue-flow/core": patch
---
Don't set user selection flags on pointer down, only setting them when pointer is moved to allow pane click events to occur when `selectionKeyCode` is `true` (i.e. selection on drag).

3
packages/core/src/container/Pane/Pane.vue
View File

@@ -150,9 +150,6 @@ function onPointerDown(event: PointerEvent) {
y,
}
userSelectionActive.value = true
nodesSelectionActive.value = false
emits.selectionStart(event)
}

2
packages/core/src/container/Viewport/Viewport.vue
View File

@@ -66,7 +66,7 @@ const selectionKeyPressed = useKeyPress(selectionKeyCode)
const zoomKeyPressed = useKeyPress(zoomActivationKeyCode)
const shouldPanOnDrag = toRef(() => panKeyPressed.value || panOnDrag.value)
const shouldPanOnDrag = toRef(() => !selectionKeyPressed.value && (panKeyPressed.value || panOnDrag.value))
const shouldPanOnScroll = toRef(() => panKeyPressed.value || panOnScroll.value)

5
packages/core/src/types/store.ts
View File

@@ -279,10 +279,7 @@ export interface Actions extends Omit<ViewportHelper, 'viewportInitialized'> {
removeSelectedEdges: (edges: GraphEdge[]) => void
/** manually unselect nodes and remove from state */
removeSelectedNodes: (nodes: GraphNode[]) => void
/**
* @deprecated will be replaced in the next major
* unselect selected elements (if none are passed, all elements are unselected)
*/
/** unselect selected elements (if none are passed, all elements are unselected) */
removeSelectedElements: (elements?: Elements) => void
/** apply min zoom value to d3 */
setMinZoom: (zoom: number) => void