fix(core): don't set user selection flags on pointer down (#1600)

* chore(core): remove deprecation of `removeSelectedElements` Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com> * fix(core): don't set user selection flags on pointer down Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com> * fix(core): prevent panning on drag when selection is active Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com> * chore(changeset): add Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com> --------- Signed-off-by: braks <78412429+bcakmakoglu@users.noreply.github.com>
2024-08-30 12:45:11 +02:00
parent 9c003d4353
commit eb12bdc56f
4 changed files with 7 additions and 8 deletions
@@ -150,9 +150,6 @@ function onPointerDown(event: PointerEvent) {
    y,
  }

-  userSelectionActive.value = true
-  nodesSelectionActive.value = false
-
  emits.selectionStart(event)
 }

@@ -66,7 +66,7 @@ const selectionKeyPressed = useKeyPress(selectionKeyCode)

 const zoomKeyPressed = useKeyPress(zoomActivationKeyCode)

-const shouldPanOnDrag = toRef(() => panKeyPressed.value || panOnDrag.value)
+const shouldPanOnDrag = toRef(() => !selectionKeyPressed.value && (panKeyPressed.value || panOnDrag.value))

 const shouldPanOnScroll = toRef(() => panKeyPressed.value || panOnScroll.value)

@@ -279,10 +279,7 @@ export interface Actions extends Omit<ViewportHelper, 'viewportInitialized'> {
  removeSelectedEdges: (edges: GraphEdge[]) => void
  /** manually unselect nodes and remove from state */
  removeSelectedNodes: (nodes: GraphNode[]) => void
-  /**
-   * @deprecated will be replaced in the next major
-   * unselect selected elements (if none are passed, all elements are unselected)
-   */
+  /** unselect selected elements (if none are passed, all elements are unselected) */
  removeSelectedElements: (elements?: Elements) => void
  /** apply min zoom value to d3 */
  setMinZoom: (zoom: number) => void