alighasami/xyflow
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #4722 from xyflow/chore/selected-nodes-internal

Browse Source 
fix(react): use internal nodes for deselecting node #4716
This commit is contained in:
Moritz Klack
2024-10-09 17:17:01 +02:00
committed by GitHub
parent eb71e34d44 e816bb6953
commit 2d02860ff1
2 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/stale-owls-turn.md Normal file
View File

@@ -0,0 +1,5 @@
---
'@xyflow/react': patch
---
Fix internal behaviour that mutated user nodes which led to an issue with Redux and immer

11
packages/react/src/store/index.ts
View File

@@ -238,12 +238,17 @@ const createStore = ({
triggerNodeChanges(getSelectionChanges(nodeLookup, new Set(), true));
},
unselectNodesAndEdges: ({ nodes, edges }: UnselectNodesAndEdgesParams = {}) => {
const { edges: storeEdges, nodes: storeNodes, triggerNodeChanges, triggerEdgeChanges } = get();
const { edges: storeEdges, nodes: storeNodes, nodeLookup, triggerNodeChanges, triggerEdgeChanges } = get();
const nodesToUnselect = nodes ? nodes : storeNodes;
const edgesToUnselect = edges ? edges : storeEdges;
const nodeChanges = nodesToUnselect.map((n) => {
n.selected = false;
const internalNode = nodeLookup.get(n.id);
if (internalNode) {
// we need to unselect the internal node that was selected previously before we
// send the change to the user to prevent it to be selected while dragging the new node
internalNode.selected = false;
}
return createSelectionChange(n.id, false);
});
const edgeChanges = edgesToUnselect.map((edge) => createSelectionChange(edge.id, false));