Merge pull request #5468 from xyflow/svelte-fix-onbeforeconnect

Svelte fix onbeforeconnect

.changeset/quick-radios-yell.md

@@ -0,0 +1,5 @@
+---
+'@xyflow/svelte': patch
+---
+
+Allow returning void, false and null from onbeforeconnect

packages/svelte/src/lib/components/EdgeReconnectAnchor/EdgeReconnectAnchor.svelte

@@ -50,7 +50,6 @@
       edgeLookup
     } = store;
 
-    let newEdge: Edge | undefined;
     let edge = edgeLookup.get(edgeId)!;
 
     const _onConnectStart: OnConnectStart = (evt, params) => {
@@ -86,13 +85,16 @@
       onConnectStart: _onConnectStart,
       onConnectEnd: onconnectend,
       onConnect: (connection) => {
-        newEdge = { ...edge, ...connection };
-        newEdge = onbeforereconnect ? (onbeforereconnect(newEdge, edge) ?? undefined) : newEdge;
+        const reconnectedEdge = { ...edge, ...connection };
+        const newEdge = onbeforereconnect
+          ? onbeforereconnect(reconnectedEdge, edge)
+          : reconnectedEdge;
 
-        if (newEdge) {
-          store.edges = store.edges.map((e) => (e.id === edge.id ? (newEdge as Edge) : e));
+        if (!newEdge) {
+          return;
         }
 
+        store.edges = store.edges.map((e) => (e.id === edge.id ? (newEdge as Edge) : e));
         onreconnect?.(edge, connection);
       },
       onReconnectEnd: (event, connectionState) => {

packages/svelte/src/lib/components/Handle/Handle.svelte

@@ -98,7 +98,7 @@
     });
 
   function onConnectExtended(connection: Connection) {
-    const edge = store.onbeforeconnect?.(connection) ?? connection;
+    const edge = store.onbeforeconnect ? store.onbeforeconnect(connection) : connection;
 
     if (!edge) {
       return;

packages/svelte/src/lib/types/general.ts

@@ -38,11 +38,11 @@ export type OnDelete<NodeType extends Node = Node, EdgeType extends Edge = Edge>
 
 export type OnBeforeConnect<EdgeType extends Edge = Edge> = (
   connection: Connection
-) => EdgeType | Connection | void;
+) => EdgeType | Connection | void | false | null;
 export type OnBeforeReconnect<EdgeType extends Edge = Edge> = (
   newEdge: EdgeType,
   oldEdge: EdgeType
-) => EdgeType | void;
+) => EdgeType | void | false | null;
 export type OnBeforeDelete<
   NodeType extends Node = Node,
   EdgeType extends Edge = Edge