alighasami/xyflow
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(xydrag): handle deleted nodes while dragging #4677

Browse Source
This commit is contained in:
moklick
2024-09-23 16:27:41 +02:00
parent 74262a7c67
commit 7a923bec4a
1 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
packages/system/src/xydrag/XYDrag.ts
View File

@@ -139,6 +139,12 @@ export function XYDrag<OnNodeDrag extends (e: any, nodes: any, node: any) => voi
}
for (const [id, dragItem] of dragItems) {
if (!nodeLookup.has(id)) {
// if the node is not in the nodeLookup anymore, it was probably deleted while dragging
// and we don't need to update it anymore
continue;
}
let nextPosition = { x: x - dragItem.distance.x, y: y - dragItem.distance.y };
if (snapToGrid) {
nextPosition = snapPosition(nextPosition, snapGrid);
@@ -288,10 +294,14 @@ export function XYDrag<OnNodeDrag extends (e: any, nodes: any, node: any) => voi
mousePosition = getEventPosition(event.sourceEvent, containerBounds!);
})
.on('drag', (event: UseDragEvent) => {
const { autoPanOnNodeDrag, transform, snapGrid, snapToGrid, nodeDragThreshold } = getStoreItems();
const { autoPanOnNodeDrag, transform, snapGrid, snapToGrid, nodeDragThreshold, nodeLookup } = getStoreItems();
const pointerPos = getPointerPosition(event.sourceEvent, { transform, snapGrid, snapToGrid });
if (event.sourceEvent.type === 'touchmove' && event.sourceEvent.touches.length > 1) {
if (
(event.sourceEvent.type === 'touchmove' && event.sourceEvent.touches.length > 1) ||
// if user deletes a node while dragging, we need to abort the drag to prevent errors
(nodeId && !nodeLookup.has(nodeId))
) {
abortDrag = true;
}