hidden nodes dont crash application on unmount anymore, hidden elements get correctly unobserved

2024-04-03 09:59:27 +02:00
parent d775012e1b
commit a1fd1aee9c
1 changed files with 7 additions and 2 deletions
--- a/packages/svelte/src/lib/components/NodeWrapper/NodeWrapper.svelte
+++ b/packages/svelte/src/lib/components/NodeWrapper/NodeWrapper.svelte
@@ -58,7 +58,7 @@
  const nodeType = type || 'default';

  let nodeRef: HTMLDivElement;
-  let prevNodeRef: HTMLDivElement;
+  let prevNodeRef: HTMLDivElement | null = null;

  const nodeTypeValid = !!$nodeTypes[nodeType];

@@ -129,11 +129,16 @@
        resizeObserver?.observe(nodeRef);
        prevNodeRef = nodeRef;
      }
+    } else if (prevNodeRef) {
+      resizeObserver?.unobserve(prevNodeRef);
+      prevNodeRef = null;
    }
  }

  onDestroy(() => {
-    resizeObserver?.unobserve(nodeRef);
+    if (prevNodeRef) {
+      resizeObserver?.unobserve(prevNodeRef);
+    }
  });

  function onSelectNodeHandler(event: MouseEvent | TouchEvent) {