Merge pull request #5637 from xyflow/feat/zindexmode

feat(nodes-edges): add zIndexMode
This commit is contained in:
Moritz Klack
2025-12-03 14:31:23 +01:00
committed by GitHub
25 changed files with 256 additions and 46 deletions

View File

@@ -0,0 +1,7 @@
---
'@xyflow/react': minor
'@xyflow/svelte': minor
'@xyflow/system': patch
---
Add `zIndexMode` to control how z-index is calculated for nodes and edges

View File

@@ -60,6 +60,7 @@ import DevTools from '../examples/DevTools';
import Redux from '../examples/Redux';
import MovingHandles from '../examples/MovingHandles';
import DetachedHandle from '../examples/DetachedHandle';
import ZIndexMode from '../examples/ZIndexMode';
import Middlewares from '../examples/Middlewares';
export interface IRoute {
@@ -384,6 +385,11 @@ const routes: IRoute[] = [
path: 'use-key-press',
component: UseKeyPress,
},
{
name: 'zIndexMode',
path: 'z-index-mode',
component: ZIndexMode,
},
];
export default routes;

View File

@@ -15,8 +15,6 @@ import {
Position,
} from '@xyflow/react';
import './style.css';
const nodeDefaults = {
sourcePosition: Position.Right,
targetPosition: Position.Left,

View File

@@ -0,0 +1,88 @@
import { ChangeEventHandler, useCallback, useState } from 'react';
import {
ReactFlow,
addEdge,
Node,
useNodesState,
useEdgesState,
OnConnect,
Edge,
MiniMap,
Background,
Controls,
Position,
ZIndexMode,
Panel,
} from '@xyflow/react';
const nodeDefaults = {
sourcePosition: Position.Right,
targetPosition: Position.Left,
};
const initialNodes: Node[] = [
{ id: 'A', type: 'input', position: { x: 0, y: 150 }, data: { label: 'A' }, ...nodeDefaults },
{ id: 'B', position: { x: 250, y: 0 }, data: { label: 'B' }, ...nodeDefaults },
{ id: 'C', position: { x: 250, y: 150 }, data: { label: 'C' }, ...nodeDefaults },
// group 1
{ id: 'D', position: { x: 0, y: 300 }, width: 200, height: 200, data: { label: 'D' }, ...nodeDefaults },
{ id: 'E', parentId: 'D', position: { x: 10, y: 10 }, data: { label: 'E' }, ...nodeDefaults },
// group 2
{ id: 'F', position: { x: 250, y: 300 }, width: 200, height: 200, data: { label: 'F' }, ...nodeDefaults },
{ id: 'G', parentId: 'F', position: { x: 10, y: 10 }, data: { label: 'G' }, ...nodeDefaults },
// group 3
{ id: 'H', position: { x: 500, y: 300 }, width: 200, height: 200, data: { label: 'H' }, ...nodeDefaults },
{ id: 'I', parentId: 'H', position: { x: 10, y: 10 }, data: { label: 'I' }, ...nodeDefaults },
];
const initialEdges: Edge[] = [
{
id: 'A-B',
source: 'A',
target: 'B',
},
{
id: 'A-C',
source: 'A',
target: 'C',
},
];
function ZIndexModeFlow() {
const [zIndexMode, setZIndexMode] = useState<ZIndexMode>('auto');
const [nodes, , onNodesChange] = useNodesState(initialNodes);
const [edges, setEdges, onEdgesChange] = useEdgesState(initialEdges);
const onConnect: OnConnect = useCallback((params) => setEdges((eds) => addEdge(params, eds)), [setEdges]);
const onChange: ChangeEventHandler<HTMLSelectElement> = (evt) => setZIndexMode(evt.target.value as ZIndexMode);
return (
<ReactFlow
nodes={nodes}
edges={edges}
onNodesChange={onNodesChange}
onEdgesChange={onEdgesChange}
onConnect={onConnect}
zIndexMode={zIndexMode}
fitView
>
<MiniMap />
<Background />
<Controls />
<Panel position="top-right">
<select value={zIndexMode} onChange={onChange} data-testid="zindexmode-select">
<option value="manual">manual</option>
<option value="basic">basic</option>
<option value="auto">auto</option>
</select>
</Panel>
</ReactFlow>
);
}
export default ZIndexModeFlow;

View File

@@ -89,6 +89,7 @@ function EdgeWrapper<EdgeType extends Edge = Edge>({
sourceNode,
targetNode,
elevateOnSelect: store.elevateEdgesOnSelect,
zIndexMode: store.zIndexMode,
});
return {

View File

@@ -4,7 +4,7 @@ import { Provider } from '../../contexts/StoreContext';
import { createStore } from '../../store';
import { BatchProvider } from '../BatchProvider';
import type { Node, Edge, FitViewOptions } from '../../types';
import { CoordinateExtent, NodeOrigin } from '@xyflow/system';
import { CoordinateExtent, NodeOrigin, ZIndexMode } from '@xyflow/system';
export type ReactFlowProviderProps = {
/** These nodes are used to initialize the flow. They are not dynamic. */
@@ -48,6 +48,7 @@ export type ReactFlowProviderProps = {
*/
nodeExtent?: CoordinateExtent;
children: ReactNode;
zIndexMode?: ZIndexMode;
};
/**
@@ -97,6 +98,7 @@ export function ReactFlowProvider({
fitView,
nodeOrigin,
nodeExtent,
zIndexMode,
children,
}: ReactFlowProviderProps) {
const [store] = useState(() =>
@@ -113,6 +115,7 @@ export function ReactFlowProvider({
fitViewOptions,
nodeOrigin,
nodeExtent,
zIndexMode,
})
);

View File

@@ -70,6 +70,7 @@ const reactFlowFieldsToTrack = [
'debug',
'autoPanSpeed',
'ariaLabelConfig',
'zIndexMode',
] as const;
type ReactFlowFieldsToTrack = (typeof reactFlowFieldsToTrack)[number];

View File

@@ -3,7 +3,7 @@ import { useContext, type ReactNode } from 'react';
import StoreContext from '../../contexts/StoreContext';
import { ReactFlowProvider } from '../../components/ReactFlowProvider';
import type { Node, Edge, FitViewOptions } from '../../types';
import { CoordinateExtent, NodeOrigin } from '@xyflow/system';
import { CoordinateExtent, NodeOrigin, ZIndexMode } from '@xyflow/system';
export function Wrapper({
children,
@@ -19,6 +19,7 @@ export function Wrapper({
maxZoom,
nodeOrigin,
nodeExtent,
zIndexMode,
}: {
children: ReactNode;
nodes?: Node[];
@@ -33,6 +34,7 @@ export function Wrapper({
maxZoom?: number;
nodeOrigin?: NodeOrigin;
nodeExtent?: CoordinateExtent;
zIndexMode?: ZIndexMode;
}) {
const isWrapped = useContext(StoreContext);
@@ -58,6 +60,7 @@ export function Wrapper({
initialMaxZoom={maxZoom}
nodeOrigin={nodeOrigin}
nodeExtent={nodeExtent}
zIndexMode={zIndexMode}
>
{children}
</ReactFlowProvider>

View File

@@ -127,8 +127,8 @@ function ReactFlow<NodeType extends Node = Node, EdgeType extends Edge = Edge>(
attributionPosition,
proOptions,
defaultEdgeOptions,
elevateNodesOnSelect,
elevateEdgesOnSelect,
elevateNodesOnSelect = true,
elevateEdgesOnSelect = false,
disableKeyboardA11y = false,
autoPanOnConnect,
autoPanOnNodeDrag,
@@ -148,6 +148,7 @@ function ReactFlow<NodeType extends Node = Node, EdgeType extends Edge = Edge>(
debug,
onScroll,
ariaLabelConfig,
zIndexMode = 'basic',
...rest
}: ReactFlowProps<NodeType, EdgeType>,
ref: ForwardedRef<HTMLDivElement>
@@ -186,6 +187,7 @@ function ReactFlow<NodeType extends Node = Node, EdgeType extends Edge = Edge>(
maxZoom={maxZoom}
nodeOrigin={nodeOrigin}
nodeExtent={nodeExtent}
zIndexMode={zIndexMode}
>
<GraphView<NodeType, EdgeType>
onInit={onInit}
@@ -311,6 +313,7 @@ function ReactFlow<NodeType extends Node = Node, EdgeType extends Edge = Edge>(
onBeforeDelete={onBeforeDelete}
debug={debug}
ariaLabelConfig={ariaLabelConfig}
zIndexMode={zIndexMode}
/>
<SelectionListener<NodeType, EdgeType> onSelectionChange={onSelectionChange} />
{children}

View File

@@ -116,6 +116,7 @@ export {
type SetViewport,
type FitBounds,
type HandleConnection,
type ZIndexMode,
} from '@xyflow/system';
// we need this workaround to prevent a duplicate identifier error

View File

@@ -16,6 +16,7 @@ import {
fitViewport,
getHandlePosition,
Position,
ZIndexMode
} from '@xyflow/system';
import { applyEdgeChanges, applyNodeChanges, createSelectionChange, getSelectionChanges } from '../utils/changes';
@@ -35,6 +36,7 @@ const createStore = ({
maxZoom,
nodeOrigin,
nodeExtent,
zIndexMode,
}: {
nodes?: Node[];
edges?: Edge[];
@@ -48,6 +50,7 @@ const createStore = ({
maxZoom?: number;
nodeOrigin?: NodeOrigin;
nodeExtent?: CoordinateExtent;
zIndexMode?: ZIndexMode;
}) =>
createWithEqualityFn<ReactFlowState>((set, get) => {
async function resolveFitView() {
@@ -91,9 +94,10 @@ const createStore = ({
nodeExtent,
defaultNodes,
defaultEdges,
zIndexMode,
}),
setNodes: (nodes: Node[]) => {
const { nodeLookup, parentLookup, nodeOrigin, elevateNodesOnSelect, fitViewQueued } = get();
const { nodeLookup, parentLookup, nodeOrigin, elevateNodesOnSelect, fitViewQueued, zIndexMode } = get();
/*
* setNodes() is called exclusively in response to user actions:
* - either when the `<ReactFlow nodes>` prop is updated in the controlled ReactFlow setup,
@@ -108,6 +112,7 @@ const createStore = ({
nodeExtent,
elevateNodesOnSelect,
checkEquality: true,
zIndexMode,
});
if (fitViewQueued && nodesInitialized) {
@@ -142,8 +147,17 @@ const createStore = ({
* new dimensions and update the nodes.
*/
updateNodeInternals: (updates) => {
const { triggerNodeChanges, nodeLookup, parentLookup, domNode, nodeOrigin, nodeExtent, debug, fitViewQueued } =
get();
const {
triggerNodeChanges,
nodeLookup,
parentLookup,
domNode,
nodeOrigin,
nodeExtent,
debug,
fitViewQueued,
zIndexMode,
} = get();
const { changes, updatedInternals } = updateNodeInternalsSystem(
updates,
@@ -151,14 +165,15 @@ const createStore = ({
parentLookup,
domNode,
nodeOrigin,
nodeExtent
nodeExtent,
zIndexMode
);
if (!updatedInternals) {
return;
}
updateAbsolutePositions(nodeLookup, parentLookup, { nodeOrigin, nodeExtent });
updateAbsolutePositions(nodeLookup, parentLookup, { nodeOrigin, nodeExtent, zIndexMode });
if (fitViewQueued) {
resolveFitView();
@@ -343,7 +358,7 @@ const createStore = ({
triggerEdgeChanges(edgeChanges);
},
setNodeExtent: (nextNodeExtent) => {
const { nodes, nodeLookup, parentLookup, nodeOrigin, elevateNodesOnSelect, nodeExtent } = get();
const { nodes, nodeLookup, parentLookup, nodeOrigin, elevateNodesOnSelect, nodeExtent, zIndexMode } = get();
if (
nextNodeExtent[0][0] === nodeExtent[0][0] &&
@@ -359,6 +374,7 @@ const createStore = ({
nodeExtent: nextNodeExtent,
elevateNodesOnSelect,
checkEquality: false,
zIndexMode,
});
set({ nodeExtent: nextNodeExtent });

View File

@@ -11,6 +11,7 @@ import {
initialConnection,
CoordinateExtent,
defaultAriaLabelConfig,
ZIndexMode,
} from '@xyflow/system';
import type { Edge, FitViewOptions, InternalNode, Node, ReactFlowStore } from '../types';
@@ -28,6 +29,7 @@ const getInitialState = ({
maxZoom = 2,
nodeOrigin,
nodeExtent,
zIndexMode = 'basic',
}: {
nodes?: Node[];
edges?: Edge[];
@@ -41,6 +43,7 @@ const getInitialState = ({
maxZoom?: number;
nodeOrigin?: NodeOrigin;
nodeExtent?: CoordinateExtent;
zIndexMode?: ZIndexMode;
} = {}): ReactFlowStore => {
const nodeLookup = new Map<string, InternalNode>();
const parentLookup = new Map();
@@ -56,7 +59,7 @@ const getInitialState = ({
const nodesInitialized = adoptUserNodes(storeNodes, nodeLookup, parentLookup, {
nodeOrigin: storeNodeOrigin,
nodeExtent: storeNodeExtent,
elevateNodesOnSelect: false,
zIndexMode,
});
let transform: Transform = [0, 0, 1];
@@ -119,7 +122,7 @@ const getInitialState = ({
edgesReconnectable: true,
elementsSelectable: true,
elevateNodesOnSelect: true,
elevateEdgesOnSelect: false,
elevateEdgesOnSelect: true,
selectNodesOnDrag: true,
multiSelectionActive: false,
@@ -146,6 +149,7 @@ const getInitialState = ({
lib: 'react',
debug: false,
ariaLabelConfig: defaultAriaLabelConfig,
zIndexMode,
onNodesChangeMiddlewareMap: new Map(),
onEdgesChangeMiddlewareMap: new Map(),

View File

@@ -23,6 +23,7 @@ import type {
OnReconnect,
AriaLabelConfig,
FinalConnectionState,
ZIndexMode,
} from '@xyflow/system';
import type {
@@ -691,4 +692,11 @@ export interface ReactFlowProps<NodeType extends Node = Node, EdgeType extends E
* Allows localization, customization of ARIA descriptions, control labels, minimap labels, and other UI strings.
*/
ariaLabelConfig?: Partial<AriaLabelConfig>;
/**
* Used to define how z-indexing is calculated for nodes and edges.
* 'auto' is for selections and sub flows, 'basic' for selections only, and 'manual' for no auto z-indexing.
*
* @default 'basic'
*/
zIndexMode?: ZIndexMode;
}

View File

@@ -29,7 +29,8 @@ import {
type EdgeChange,
type ParentLookup,
type AriaLabelConfig,
SetCenter,
type SetCenter,
type ZIndexMode,
} from '@xyflow/system';
import type {
@@ -153,6 +154,7 @@ export type ReactFlowStore<NodeType extends Node = Node, EdgeType extends Edge =
debug: boolean;
ariaLabelConfig: AriaLabelConfig;
zIndexMode: ZIndexMode;
onNodesChangeMiddlewareMap: Map<symbol, (changes: NodeChange<NodeType>[]) => NodeChange<NodeType>[]>;
onEdgesChangeMiddlewareMap: Map<symbol, (changes: EdgeChange<EdgeType>[]) => EdgeChange<EdgeType>[]>;
};

View File

@@ -75,7 +75,7 @@
}: SvelteFlowProps<NodeType, EdgeType> &
Omit<HTMLAttributes<HTMLDivElement>, 'onselectionchange'> = $props();
// svelte-ignore non_reactive_update
// svelte-ignore non_reactive_update, state_referenced_locally
let store = createStore<NodeType, EdgeType>({
props,
width,

View File

@@ -96,6 +96,7 @@
ariaLabelConfig,
autoPanSpeed,
panOnScrollSpeed,
zIndexMode,
...divAttributes
} = $derived(rest);
/* eslint-enable @typescript-eslint/no-unused-vars */

View File

@@ -21,7 +21,8 @@ import type {
OnReconnect,
OnReconnectStart,
OnReconnectEnd,
AriaLabelConfig
AriaLabelConfig,
ZIndexMode
} from '@xyflow/system';
import type {
@@ -500,4 +501,11 @@ export type SvelteFlowProps<
* Allows localization, customization of ARIA descriptions, control labels, minimap labels, and other UI strings.
*/
ariaLabelConfig?: Partial<AriaLabelConfig>;
/**
* Used to define how z-indexing is calculated for nodes and edges.
* 'auto' is for selections and sub flows, 'basic' for selections only, and 'manual' for no auto z-indexing.
*
* @default 'basic'
*/
zIndexMode?: ZIndexMode;
};

View File

@@ -122,7 +122,8 @@ export {
type SetCenter,
type SetViewport,
type FitBounds,
type HandleConnection
type HandleConnection,
type ZIndexMode
} from '@xyflow/system';
// system utils

View File

@@ -73,7 +73,9 @@ export function createStore<NodeType extends Node = Node, EdgeType extends Edge
store.nodeLookup,
store.parentLookup,
store.domNode,
store.nodeOrigin
store.nodeOrigin,
store.nodeExtent,
store.zIndexMode
);
if (!updatedInternals) {
@@ -82,7 +84,8 @@ export function createStore<NodeType extends Node = Node, EdgeType extends Edge
updateAbsolutePositions(store.nodeLookup, store.parentLookup, {
nodeOrigin: store.nodeOrigin,
nodeExtent: store.nodeExtent
nodeExtent: store.nodeExtent,
zIndexMode: store.zIndexMode
});
if (store.fitViewQueued) {

View File

@@ -36,7 +36,8 @@ import {
type OnReconnect,
type OnReconnectStart,
type OnReconnectEnd,
type AriaLabelConfig
type AriaLabelConfig,
type ZIndexMode
} from '@xyflow/system';
import DefaultNode from '$lib/components/nodes/DefaultNode.svelte';
@@ -116,13 +117,15 @@ export function getInitialStore<NodeType extends Node = Node, EdgeType extends E
panZoom: PanZoomInstance | null = $state.raw(null);
width = $state.raw<number>(signals.width ?? 0);
height = $state.raw<number>(signals.height ?? 0);
zIndexMode = $state.raw<ZIndexMode>(signals.props.zIndexMode ?? 'basic');
nodesInitialized: boolean = $derived.by(() => {
const nodesInitialized = adoptUserNodes(signals.nodes, this.nodeLookup, this.parentLookup, {
nodeExtent: this.nodeExtent,
nodeOrigin: this.nodeOrigin,
elevateNodesOnSelect: signals.props.elevateNodesOnSelect ?? true,
checkEquality: true
checkEquality: true,
zIndexMode: this.zIndexMode
});
if (this.fitViewQueued && nodesInitialized) {
@@ -226,7 +229,8 @@ export function getInitialStore<NodeType extends Node = Node, EdgeType extends E
connectionMode,
onerror,
onlyRenderVisibleElements,
defaultEdgeOptions
defaultEdgeOptions,
zIndexMode
} = this;
let visibleNodes: Map<string, InternalNode<NodeType>>;
@@ -239,6 +243,7 @@ export function getInitialStore<NodeType extends Node = Node, EdgeType extends E
nodeLookup,
connectionMode,
elevateEdgesOnSelect: signals.props.elevateEdgesOnSelect ?? true,
zIndexMode,
onerror
};

View File

@@ -7,7 +7,8 @@ import {
isEdgeVisible,
type NodeLookup,
type OnError,
type Transform
type Transform,
type ZIndexMode
} from '@xyflow/system';
export function getVisibleNodes<NodeType extends Node = Node>(
@@ -42,6 +43,7 @@ export interface EdgeLayoutAllOptions<NodeType extends Node = Node, EdgeType ext
transform: never;
width: never;
height: never;
zIndexMode: never;
}
export interface EdgeLayoutOnlyVisibleOptions<
@@ -53,6 +55,7 @@ export interface EdgeLayoutOnlyVisibleOptions<
width: number;
height: number;
onlyRenderVisible: true;
zIndexMode: ZIndexMode;
}
export type EdgeLayoutOptions<NodeType extends Node = Node, EdgeType extends Edge = Edge> =
@@ -70,7 +73,8 @@ export function getLayoutedEdges<NodeType extends Node = Node, EdgeType extends
connectionMode,
onerror,
onlyRenderVisible,
elevateEdgesOnSelect
elevateEdgesOnSelect,
zIndexMode
} = options;
const layoutedEdges = new Map<string, EdgeLayouted<EdgeType>>();
for (const edge of edges) {
@@ -134,7 +138,8 @@ export function getLayoutedEdges<NodeType extends Node = Node, EdgeType extends
zIndex: edge.zIndex ?? defaultEdgeOptions.zIndex,
sourceNode,
targetNode,
elevateOnSelect: elevateEdgesOnSelect
elevateOnSelect: elevateEdgesOnSelect,
zIndexMode
}),
sourceNode,
targetNode,

View File

@@ -367,3 +367,13 @@ export type OnBeforeDeleteBase<NodeType extends NodeBase = NodeBase, EdgeType ex
nodes: NodeType[];
edges: EdgeType[];
}) => Promise<boolean | { nodes: NodeType[]; edges: EdgeType[] }>;
/**
* The `ZIndexMode` type is used to define how z-indexing is calculated for nodes and edges.
* `auto` mode will automatically manage z-indexing for selections and sub flows.
* `basic` mode will only manage z-indexing for selections.
* `manual` mode does not apply any automatic z-indexing.
*
* @public
*/
export type ZIndexMode = 'auto' | 'basic' | 'manual';

View File

@@ -1,4 +1,13 @@
import { Connection, InternalNodeBase, Transform, errorMessages, isEdgeBase, EdgeBase } from '../..';
import {
Connection,
InternalNodeBase,
Transform,
errorMessages,
isEdgeBase,
EdgeBase,
ZIndexMode,
isManualZIndexMode,
} from '../..';
import { getOverlappingArea, boxToRect, nodeToBox, getBoundsOfBoxes, devWarn } from '../general';
// this is used for straight edges and simple smoothstep edges (LTR, RTL, BTT, TTB)
@@ -28,6 +37,7 @@ export type GetEdgeZIndexParams = {
selected?: boolean;
zIndex?: number;
elevateOnSelect?: boolean;
zIndexMode?: ZIndexMode;
};
/**
@@ -41,12 +51,19 @@ export function getElevatedEdgeZIndex({
selected = false,
zIndex,
elevateOnSelect = false,
zIndexMode = 'basic',
}: GetEdgeZIndexParams): number {
const manualZIndexMode = isManualZIndexMode(zIndexMode);
if (zIndex !== undefined) {
return zIndex;
}
const edgeZ = elevateOnSelect && selected ? 1000 : 0;
if (manualZIndexMode) {
return 0;
}
const edgeZ = elevateOnSelect && selected ? 1000 : 0;
const nodeZ = Math.max(
sourceNode.parentId || (elevateOnSelect && sourceNode.selected) ? sourceNode.internals.z : 0,
targetNode.parentId || (elevateOnSelect && targetNode.selected) ? targetNode.internals.z : 0

View File

@@ -1,4 +1,4 @@
import { Handle, HandleConnection, infiniteExtent, NodeHandle, NodeHandleBounds } from '..';
import { Handle, HandleConnection, infiniteExtent, NodeHandleBounds, ZIndexMode } from '..';
import {
NodeBase,
CoordinateExtent,
@@ -37,6 +37,7 @@ const defaultOptions = {
nodeOrigin: [0, 0] as NodeOrigin,
nodeExtent: infiniteExtent,
elevateNodesOnSelect: true,
zIndexMode: 'basic' as ZIndexMode,
defaults: {},
};
@@ -112,21 +113,26 @@ type UpdateNodesOptions<NodeType extends NodeBase> = {
nodeExtent?: CoordinateExtent;
elevateNodesOnSelect?: boolean;
defaults?: Partial<NodeType>;
zIndexMode?: ZIndexMode;
checkEquality?: boolean;
};
export function isManualZIndexMode(zIndexMode?: ZIndexMode): boolean {
return zIndexMode === 'manual';
}
export function adoptUserNodes<NodeType extends NodeBase>(
nodes: NodeType[],
nodeLookup: NodeLookup<InternalNodeBase<NodeType>>,
parentLookup: ParentLookup<InternalNodeBase<NodeType>>,
options?: UpdateNodesOptions<NodeType>
options: UpdateNodesOptions<NodeType> = {}
): boolean {
const _options = mergeObjects(adoptUserNodesDefaultOptions, options);
let rootParentIndex = { i: -1 };
let nodesInitialized = nodes.length > 0;
const rootParentIndex = { i: 0 };
const tmpLookup = new Map(nodeLookup);
const selectedNodeZ: number = _options?.elevateNodesOnSelect ? SELECTED_NODE_Z : 0;
const selectedNodeZ: number =
_options?.elevateNodesOnSelect && !isManualZIndexMode(_options.zIndexMode) ? SELECTED_NODE_Z : 0;
let nodesInitialized = nodes.length > 0;
nodeLookup.clear();
parentLookup.clear();
@@ -152,7 +158,7 @@ export function adoptUserNodes<NodeType extends NodeBase>(
positionAbsolute: clampedPosition,
// if user re-initializes the node or removes `measured` for whatever reason, we reset the handleBounds so that the node gets re-measured
handleBounds: parseHandles(userNode, internalNode),
z: calculateZ(userNode, selectedNodeZ),
z: calculateZ(userNode, selectedNodeZ, _options.zIndexMode),
userNode,
},
};
@@ -201,10 +207,10 @@ function updateChildNode<NodeType extends NodeBase>(
node: InternalNodeBase<NodeType>,
nodeLookup: NodeLookup<InternalNodeBase<NodeType>>,
parentLookup: ParentLookup<InternalNodeBase<NodeType>>,
options?: UpdateNodesOptions<NodeType>,
options: UpdateNodesOptions<NodeType>,
rootParentIndex?: { i: number }
) {
const { elevateNodesOnSelect, nodeOrigin, nodeExtent } = mergeObjects(defaultOptions, options);
const { elevateNodesOnSelect, nodeOrigin, nodeExtent, zIndexMode } = mergeObjects(defaultOptions, options);
const parentId = node.parentId!;
const parentNode = nodeLookup.get(parentId);
@@ -218,7 +224,12 @@ function updateChildNode<NodeType extends NodeBase>(
updateParentLookup(node, parentLookup);
// We just want to set the rootParentIndex for the first child
if (rootParentIndex && !parentNode.parentId && parentNode.internals.rootParentIndex === undefined) {
if (
rootParentIndex &&
!parentNode.parentId &&
parentNode.internals.rootParentIndex === undefined &&
zIndexMode === 'auto'
) {
parentNode.internals.rootParentIndex = ++rootParentIndex.i;
parentNode.internals.z = parentNode.internals.z + rootParentIndex.i * ROOT_PARENT_Z_INCREMENT;
}
@@ -228,8 +239,8 @@ function updateChildNode<NodeType extends NodeBase>(
rootParentIndex.i = parentNode.internals.rootParentIndex;
}
const selectedNodeZ = elevateNodesOnSelect ? SELECTED_NODE_Z : 0;
const { x, y, z } = calculateChildXYZ(node, parentNode, nodeOrigin, nodeExtent, selectedNodeZ);
const selectedNodeZ = elevateNodesOnSelect && !isManualZIndexMode(zIndexMode) ? SELECTED_NODE_Z : 0;
const { x, y, z } = calculateChildXYZ(node, parentNode, nodeOrigin, nodeExtent, selectedNodeZ, zIndexMode);
const { positionAbsolute } = node.internals;
const positionChanged = x !== positionAbsolute.x || y !== positionAbsolute.y;
@@ -246,8 +257,14 @@ function updateChildNode<NodeType extends NodeBase>(
}
}
function calculateZ(node: NodeBase, selectedNodeZ: number) {
return (isNumeric(node.zIndex) ? node.zIndex : 0) + (node.selected ? selectedNodeZ : 0);
function calculateZ(node: NodeBase, selectedNodeZ: number, zIndexMode: ZIndexMode): number {
const zIndex = isNumeric(node.zIndex) ? node.zIndex : 0;
if (isManualZIndexMode(zIndexMode)) {
return zIndex;
}
return zIndex + (node.selected ? selectedNodeZ : 0);
}
function calculateChildXYZ<NodeType extends NodeBase>(
@@ -255,7 +272,8 @@ function calculateChildXYZ<NodeType extends NodeBase>(
parentNode: InternalNodeBase<NodeType>,
nodeOrigin: NodeOrigin,
nodeExtent: CoordinateExtent,
selectedNodeZ: number
selectedNodeZ: number,
zIndexMode: ZIndexMode
) {
const { x: parentX, y: parentY } = parentNode.internals.positionAbsolute;
const childDimensions = getNodeDimensions(childNode);
@@ -274,7 +292,7 @@ function calculateChildXYZ<NodeType extends NodeBase>(
absolutePosition = clampPositionToParent(absolutePosition, childDimensions, parentNode);
}
const childZ = calculateZ(childNode, selectedNodeZ);
const childZ = calculateZ(childNode, selectedNodeZ, zIndexMode);
const parentZ = parentNode.internals.z ?? 0;
return {
@@ -378,7 +396,8 @@ export function updateNodeInternals<NodeType extends InternalNodeBase>(
parentLookup: ParentLookup<NodeType>,
domNode: HTMLElement | null,
nodeOrigin?: NodeOrigin,
nodeExtent?: CoordinateExtent
nodeExtent?: CoordinateExtent,
zIndexMode?: ZIndexMode
): { changes: (NodeDimensionChange | NodePositionChange)[]; updatedInternals: boolean } {
const viewportNode = domNode?.querySelector('.xyflow__viewport');
let updatedInternals = false;
@@ -446,7 +465,7 @@ export function updateNodeInternals<NodeType extends InternalNodeBase>(
nodeLookup.set(node.id, newNode);
if (node.parentId) {
updateChildNode(newNode, nodeLookup, parentLookup, { nodeOrigin });
updateChildNode(newNode, nodeLookup, parentLookup, { nodeOrigin, zIndexMode });
}
updatedInternals = true;