fix(onNodeDragStop): nodes are set to dragging=false

This commit is contained in:
moklick
2024-07-09 11:21:31 +02:00
parent 22a80cdfac
commit f722e2f0a3
5 changed files with 7 additions and 1 deletions
+1
View File
@@ -3,6 +3,7 @@
## 12.0.0-next.28 ## 12.0.0-next.28
- add `paneDistanceClick` prop (max distance between mousedown/up that will trigger a click) - add `paneDistanceClick` prop (max distance between mousedown/up that will trigger a click)
- returned nodes in `onNodeDragStop` are set to `dragging=false`
## 12.0.0-next.27 ## 12.0.0-next.27
-1
View File
@@ -134,7 +134,6 @@ const createStore = ({
const changes = []; const changes = [];
for (const [id, dragItem] of nodeDragItems) { for (const [id, dragItem] of nodeDragItems) {
// @todo add expandParent to drag item so that we can get rid of the look up here
const change: NodeChange = { const change: NodeChange = {
id, id,
type: 'position', type: 'position',
+1
View File
@@ -3,6 +3,7 @@
## 0.1.10 ## 0.1.10
- add `paneDistanceClick` prop (max distance between mousedown/up that will trigger a click) - add `paneDistanceClick` prop (max distance between mousedown/up that will trigger a click)
- returned nodes in `on:nodedragstop` are set to `dragging=false`
## 0.1.9 ## 0.1.9
+1
View File
@@ -332,6 +332,7 @@ export function XYDrag<OnNodeDrag extends (e: any, nodes: any, node: any) => voi
nodeId, nodeId,
dragItems, dragItems,
nodeLookup, nodeLookup,
dragging: false,
}); });
onDragStop?.(event.sourceEvent as MouseEvent, dragItems, currentNode, currentNodes); onDragStop?.(event.sourceEvent as MouseEvent, dragItems, currentNode, currentNodes);
+4
View File
@@ -81,10 +81,12 @@ export function getEventHandlerParams<NodeType extends InternalNodeBase>({
nodeId, nodeId,
dragItems, dragItems,
nodeLookup, nodeLookup,
dragging = true,
}: { }: {
nodeId?: string; nodeId?: string;
dragItems: Map<string, NodeDragItem>; dragItems: Map<string, NodeDragItem>;
nodeLookup: Map<string, NodeType>; nodeLookup: Map<string, NodeType>;
dragging?: boolean;
}): [NodeBase, NodeBase[]] { }): [NodeBase, NodeBase[]] {
const nodesFromDragItems: NodeBase[] = []; const nodesFromDragItems: NodeBase[] = [];
@@ -95,6 +97,7 @@ export function getEventHandlerParams<NodeType extends InternalNodeBase>({
nodesFromDragItems.push({ nodesFromDragItems.push({
...node, ...node,
position: dragItem.position, position: dragItem.position,
dragging,
}); });
} }
} }
@@ -109,6 +112,7 @@ export function getEventHandlerParams<NodeType extends InternalNodeBase>({
{ {
...node, ...node,
position: dragItems.get(nodeId)?.position || node.position, position: dragItems.get(nodeId)?.position || node.position,
dragging,
}, },
nodesFromDragItems, nodesFromDragItems,
]; ];