alighasami/xyflow
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #4730 from xyflow/fix/drag-crash

Browse Source 
Fix rare crash: remove non-null assertion while dragging
This commit is contained in:
Moritz Klack
2024-10-16 10:28:02 +02:00
committed by GitHub
parent de1098ad31 2c590b9078
commit 97fdff59d4
2 changed files with 15 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
.changeset/new-rocks-mate.md Normal file
View File

@@ -0,0 +1,7 @@
---
'@xyflow/system': patch
'@xyflow/react': patch
'@xyflow/svelte': patch
---
Fixed rare crash while dragging

14
packages/system/src/xydrag/utils.ts
View File

@@ -106,14 +106,16 @@ export function getEventHandlerParams<NodeType extends InternalNodeBase>({
return [nodesFromDragItems[0], nodesFromDragItems];
}
const node = nodeLookup.get(nodeId)!.internals.userNode;
const node = nodeLookup.get(nodeId)?.internals.userNode;
return [
{
...node,
position: dragItems.get(nodeId)?.position || node.position,
dragging,
},
!node
? nodesFromDragItems[0]
: {
...node,
position: dragItems.get(nodeId)?.position || node.position,
dragging,
},
nodesFromDragItems,
];
}