Merge pull request #4730 from xyflow/fix/drag-crash

Fix rare crash: remove non-null assertion while dragging
This commit is contained in:
Moritz Klack
2024-10-16 10:28:02 +02:00
committed by GitHub
2 changed files with 15 additions and 6 deletions
+7
View File
@@ -0,0 +1,7 @@
---
'@xyflow/system': patch
'@xyflow/react': patch
'@xyflow/svelte': patch
---
Fixed rare crash while dragging
+8 -6
View File
@@ -106,14 +106,16 @@ export function getEventHandlerParams<NodeType extends InternalNodeBase>({
return [nodesFromDragItems[0], nodesFromDragItems]; return [nodesFromDragItems[0], nodesFromDragItems];
} }
const node = nodeLookup.get(nodeId)!.internals.userNode; const node = nodeLookup.get(nodeId)?.internals.userNode;
return [ return [
{ !node
...node, ? nodesFromDragItems[0]
position: dragItems.get(nodeId)?.position || node.position, : {
dragging, ...node,
}, position: dragItems.get(nodeId)?.position || node.position,
dragging,
},
nodesFromDragItems, nodesFromDragItems,
]; ];
} }